Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config options to control HeadTracker's support of finality tags #13336

Merged

Conversation

dhaidashenko
Copy link
Collaborator

  • Disabled by default HeadTracker's support of finality tags
  • Added config option, that allows to abort HeadTracker's backfill if gap between the current head and latest finalized block is too large.
  • Enabled HeadTracker's support of finality tags for chains that are a testnet and max observed finality gap is less than 2000 blocks (query used to validate chain)

@dhaidashenko dhaidashenko marked this pull request as ready for review May 27, 2024 19:10
@dhaidashenko dhaidashenko requested review from a team as code owners May 27, 2024 19:10
…ity-tag

# Conflicts:
#	core/chains/evm/config/toml/defaults/BSC_Testnet.toml
@dimriou dimriou requested a review from a team May 28, 2024 11:43
@@ -57,6 +57,8 @@ TransactionPercentile = 60
HistoryDepth = 100
MaxBufferSize = 3
SamplingInterval = '1s'
FinalityTagBypass = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the default value be false otherwise every chain will override finality tag by default? AFAIK the only chain that needs this as true is Arbitrum

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO safer approach is to disable it for all of the chains and only enable it for those that we've seen behave normally. After the optimisation we will enable it for all chains.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be a bit confused here, but don't we want to enable Finality Tag on all chains they support it and if they show they have issues, then disable it by setting FinalityTagBypass = true ? Most chains don't have more than 10k finality depth. Otherwise we would have to explicitly test every chain we are operating on. I mean I'm ok either way, but we need to make sure Finality Tag is enabled on every chain we can. Same thing happened with dynamic transactions. They are still disabled in many chains because no one ever did the switch.

@dhaidashenko dhaidashenko requested a review from dimriou May 29, 2024 10:20
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@matYang matYang added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@matYang matYang added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue May 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue May 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue May 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue May 30, 2024
Merged via the queue into develop with commit 4c7e5a0 May 30, 2024
109 checks passed
@prashantkumar1982 prashantkumar1982 deleted the hotfix/BCI-3332-headtracker-disable-finality-tag branch May 30, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants