[KS-250] Use report context to validate signatures #13366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bolekk
commented
May 30, 2024
bolekk
commented
- Parse report context in write target.
- Fix 'v' value when validating signatures.
- Add a stub of KeystoneFeedsConsumer contract.
- Fix owner length in Encoder.
bolekk
force-pushed
the
feature/KS-250-report-context
branch
from
fd3e4e7
to
b72eaff
Compare
archseer
previously approved these changes
May 30, 2024
bolekk
force-pushed
the
feature/KS-250-report-context
branch
from
b72eaff
to
b6984b6
Compare
bolekk
force-pushed
the
feature/KS-250-report-context
branch
from
b6984b6
to
41bdcdb
Compare
archseer
previously approved these changes
May 30, 2024
|
@bolekk LGTM but are you missing an updated to go.mod? You'll need your chainlink-common changes won't you? |
bolekk
force-pushed
the
feature/KS-250-report-context
branch
from
b07d846
to
177130c
Compare
|
True - added. |
cedric-cordenier
previously approved these changes
May 30, 2024
1. Parse report context in write target. 2. Fix 'v' value when validating signatures. 3. Add a stub of KeystoneFeedsConsumer contract. 4. Fix owner length in Encoder.
bolekk
force-pushed
the
feature/KS-250-report-context
branch
from
177130c
to
056dd13
Compare
cedric-cordenier
approved these changes
May 30, 2024
archseer
approved these changes
May 30, 2024
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.