-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused old evm client #13380
Conversation
Quality Gate passedIssues Measures |
//go:generate mockery --quiet --name Client --output ./mocks/ --case=underscore | ||
|
||
// Client is the interface used to interact with an ethereum node. | ||
type Client interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we keep it in client.go file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep one file for interface and implementation instead of splitting them. Interfaces should live either where they are needed or if they are of general purpose inside their implementation.
func ContextWithDefaultTimeout() (ctx context.Context, cancel context.CancelFunc) { | ||
return context.WithTimeout(context.Background(), queryTimeout) | ||
} | ||
|
||
type chainClient struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we rename it to client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought of the same thing and I actually made the change locally, but then chainClient as a name kinda grew on me and decided not to make the switch. I'm happy with both to be honest.
Old evm client wasn't used and MultiNode was used in its place. The code has been deprecated for a long time. We are removing all the unnecessary files and deprecating the old evm client.