BCI-3299: Bump Starknet #13384
BCI-3299: Bump Starknet #13384
Conversation
| @@ -489,7 +489,7 @@ juelsPerFeeCoinSource = """ | |||
| answer1 [type=median index=0]; | |||
| """ | |||
| gasPriceSource = """ | |||
| gasPriceSubunitsSource = """ | |||
There was a problem hiding this comment.
why did this change? it appears to be a breaking change to the job spec for non-starknet related code. what's happening?
There was a problem hiding this comment.
It was a typo (it's supposed to begasPriceSubunitsSource originally and the rest of the test examples have gasPriceSubunitsSource).
The typo just meant that for this specific test case the gasPriceSubunitsSource pipeline was not being tested. That's ok though because it's tested in other test files so we know that the pipeline was properly being unit tested.
There was a problem hiding this comment.
You can see https://github.com/smartcontractkit/chainlink/blob/develop/core/services/feeds/service_test.go#L2472 we test with the config not set
and here we test with the config set
https://github.com/smartcontractkit/chainlink/blob/develop/core/services/feeds/service_test.go#L2434
(with the correct name)
|
* bump starknet * fix typo * add changeset * add changeset tag
* bump starknet * fix typo * add changeset * add changeset tag
This reverts commit 576e2db.
* bump starknet * fix typo * add changeset * add changeset tag
Bumping starknet to latest