ks-265 wrap local target in capability registry with transmission logic #13396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ettec
force-pushed
the
shim-for-local-transmission-protocol
branch
from
44f6799
to
339b329
Compare
ettec
force-pushed
the
shim-for-local-transmission-protocol
branch
from
116aba1
to
e47e671
Compare
ettec
force-pushed
the
shim-for-local-transmission-protocol
branch
from
09f4fb6
to
4323490
Compare
ettec
force-pushed
the
shim-for-local-transmission-protocol
branch
from
4323490
to
51292df
Compare
ettec
force-pushed
the
shim-for-local-transmission-protocol
branch
from
dbe6559
to
1c588d6
Compare
cedric-cordenier
previously approved these changes
Jun 3, 2024
cedric-cordenier
approved these changes
Jun 3, 2024
krehermann
approved these changes
Jun 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
bolekk
reviewed
Jun 3, 2024
| } | ||
|
|
||
| if opts.CapabilitiesRegistry == nil { | ||
| peerID := externalPeerWrapper.GetPeer().ID() |
There was a problem hiding this comment.
This won't work. Peer is ready only after the wrapper is Start()-ed.
There was a problem hiding this comment.
PeerID is currently extracted from Keystore and that is not accessible until the services start.
bolekk
reviewed
Jun 3, 2024
| return nil, fmt.Errorf("failed to create hardcoded Don network setup: %w", err) | ||
| } | ||
|
|
||
| if opts.CapabilitiesRegistry == nil { |
There was a problem hiding this comment.
Can this ever be nil? Registry is created in shell.go.
bolekk
added a commit
that referenced
this pull request
Jun 3, 2024
See comments on #13396 Registry can't easily access PeerID when it is being created. This fix moves desired wrapping to the Engine.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
See comments on #13396 Registry can't easily access PeerID when it is being created. This fix moves desired wrapping to the Engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.