[TT-1326] Update Solidty Foundry pipeline with Slither #13986
Conversation
Tofel
force-pushed
the
tt_1326_update_Sol_Foundry
branch
from
7d0f304
to
4326696
Compare
| product: | ||
| # 98.5 is the aspirational code coverage once we migrate all tests to Foundry | ||
| # product that have that minimum coverage of 98.5 in the matrix below are currently excluded from the check | ||
| - name: automation |
There was a problem hiding this comment.
Is it possible to move this to the top of the file, and also add the info if products have a gas snapshot, and if they use forge fmt? That would be a good single source of truth for all CI in this file
There was a problem hiding this comment.
this is a really cool idea!
| @@ -11,28 +11,55 @@ jobs: | |||
| name: Detect changes | |||
| runs-on: ubuntu-latest | |||
| outputs: | |||
| changes: ${{ steps.changes.outputs.src }} | |||
| src_changes: ${{ steps.changes.outputs.src }} | |||
There was a problem hiding this comment.
I think it makes sense to check for changes in the folders per product. Right now we would be running coverage for all products if any single one changes a line. Ideally, CI only runs for affected products.
Any changes to vendor or shared would trigger a full run, don't think we can get around that
| run: | | ||
| forge fmt --check | ||
| SOL_FILES="${{ needs.changes.outputs.sol_files }}" |
There was a problem hiding this comment.
Do we need this over the extremely simple check we had before? This is lightning fast
… an action, remove whitespaces
|
Running everything, when
sharedfile changed: https://github.com/smartcontractkit/chainlink/actions/runs/10200971215Running only one product: https://github.com/smartcontractkit/chainlink/actions/runs/10201139248