Allow retrying failed transmissions #14017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeividasK
changed the base branch from
develop
to
dk-disallow-zero-address-signers
LCOV of commit
|
DeividasK
force-pushed
the
dk-call-with-exact-gas
branch
from
8f08869
to
a502356
Compare
DeividasK
force-pushed
the
dk-call-with-exact-gas
branch
from
686e080
to
c19c0fb
Compare
DeividasK
requested review from
bolekk,
patrick-dowell,
RensR and
a team
as code owners
bolekk
reviewed
Aug 7, 2024
| assembly { | ||
| // call and return whether we succeeded. ignore return data | ||
| // call(gas,addr,value,argsOffset,argsLength,retOffset,retLength) | ||
| success := call(gasLimit, receiver, 0, add(payload, 0x20), mload(payload), 0x0, 0x0) |
There was a problem hiding this comment.
That success == false mean any reason for revert or only out of gas?
There was a problem hiding this comment.
It can be either a revert (for whatever user reason) or out of gas (technically, still a revert).
cds95
reviewed
Aug 7, 2024
| /// @dev The gas we require to revert in case of a revert in the call to the | ||
| /// receiver. This is more than enough and does not attempt to be exact. | ||
| uint256 internal constant REQUIRED_GAS_FOR_ROUTING = 40_000; | ||
| bytes4 internal constant INSUFFICIENT_GAS_FOR_ROUTING_SIG = 0x0bfecd63; |
There was a problem hiding this comment.
Do we want to add a NatSpec comment for this?
There was a problem hiding this comment.
Removed it as it is unused 🙈
| // ================================================================ | ||
| // │ Router │ | ||
| // ================================================================ | ||
|
|
||
| mapping(address forwarder => bool) internal s_forwarders; | ||
| mapping(bytes32 transmissionId => TransmissionInfo) internal s_transmissions; | ||
| mapping(bytes32 transmissionId => Transmission) internal s_transmissions; |
There was a problem hiding this comment.
Suggested change
| mapping(bytes32 transmissionId => Transmission) internal s_transmissions; | |
| mapping(bytes32 transmissionId => Transmission transmission) internal s_transmissions; |
| success := call(gasLimit, receiver, 0, add(payload, 0x20), mload(payload), 0x0, 0x0) | ||
| } | ||
|
|
||
| if (success) { |
There was a problem hiding this comment.
Is this check just to prevent the storage write?
|
cds95
approved these changes
Aug 7, 2024
bolekk
approved these changes
Aug 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
momentmaker
added a commit
that referenced
this pull request
Aug 8, 2024
* develop: CRIB CI integration (#13924) fix: refactor sonarqube scan args (#13875) BCI-3492 [LogPoller]: Allow withObservedExecAndRowsAffected to report non-zero rows affected (#14057) Add error mapping for Astar (#13990) [BCI-3862][chainlink] - Change DSL Block primitive to string instead of int (#14033) [KS-412] Validate called DON membership in TriggerPublisher (#14040) [TT-1429] notifying guardian on some failures (#14073) Add Mantle errors (#14053) Fix write target nil dereferences (#14059) Allow retrying failed transmissions (#14017) auto-11214: migrate more tests to foundry (#13934)
This was referenced Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On-chain:
Off-chain: