You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix keystone e2e test dispatcher to correctly replicate duplicate registration behaviour. The syncer relies on the dispatcher returning a ErrReceiverExists error code to prevent duplicate creation of a capability. The mocked dispatcher used for the e2e test was not replicating this behaviour resulting in duplicate registration of trigger publisher.
@ettec One point of feedback (which shouldn't block this) is that I wonder if we could increase our overall coverage by mocking out the external peer wrapper, rather than just the dispatcher? That would allow us to bring the registrysyncer, launcher and dispatcher in scope and would have eliminated this bug.
@ettec One point of feedback (which shouldn't block this) is that I wonder if we could increase our overall coverage by mocking out the external peer wrapper, rather than just the dispatcher? That would allow us to bring the registrysyncer, launcher and dispatcher in scope and would have eliminated this bug.
The registrysyncer and launcher are already used in the test, unless you mean something else by bring them in scope?
@ettec Nope, just a brainfart on my end: I meant bringing the dispatcher entirely within scope -- so effectively the only thing out of scope would be the actual networking (+ OCR itself)
@ettec Nope, just a brainfart on my end: I meant bringing the dispatcher entirely within scope -- so effectively the only thing out of scope would be the actual networking (+ OCR itself)
looks like it could work, a brief look at the p2p wrapper usage in the dispatcher would seem to suggest it would be relatively straightforward
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ettec
force-pushed
the
keystone-e2e-test-mock-dispatcher-fix
branch
from
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fix keystone e2e test dispatcher to correctly replicate duplicate registration behaviour. The syncer relies on the dispatcher returning a
ErrReceiverExistserror code to prevent duplicate creation of a capability. The mocked dispatcher used for the e2e test was not replicating this behaviour resulting in duplicate registration of trigger publisher.