Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add hexutil Bytes encoding to batchcall data #14165

Merged
merged 9 commits into from
Aug 21, 2024
Merged

Fix: Add hexutil Bytes encoding to batchcall data #14165

merged 9 commits into from
Aug 21, 2024

Conversation

silaslenihan
Copy link
Contributor

@silaslenihan silaslenihan commented Aug 20, 2024 •
edited by jira bot
Loading

Requires Dependencies

Resolves Dependencies

BCI-3498

@silaslenihan silaslenihan requested a review from a team as a code owner August 20, 2024 14:49
@silaslenihan silaslenihan changed the title cccccbldulfrljrtigjfgfgbdkldeficdlitikfrhdrlFix: Add hexutil Bytes encoding to batchcall data Fix: Add hexutil Bytes encoding to batchcall data Aug 20, 2024
Farber98
Farber98 reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@Farber98 Farber98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me but don't have full context to mark it as green

@EasterTheBunny EasterTheBunny added this pull request to the merge queue Aug 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 21, 2024
@ilija42 ilija42 enabled auto-merge August 21, 2024 18:10
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ilija42 ilija42 added this pull request to the merge queue Aug 21, 2024
Merged via the queue into develop with commit e76463c Aug 21, 2024
135 of 136 checks passed
@ilija42 ilija42 deleted the batchcall-fix branch August 21, 2024 19:36
This was referenced Aug 21, 2024
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EasterTheBunny EasterTheBunny EasterTheBunny approved these changes

@Farber98 Farber98 Farber98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silaslenihan @EasterTheBunny @Farber98 @ilija42