fix(RegisterManager): handle error correctly #14183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graham-chainlink
force-pushed
the
ggoh/handle-create-manager-error
branch
2 times, most recently
from
ecbd87a
to
b56ce8f
Compare
eutopian
previously approved these changes
Aug 22, 2024
|
Nice find!! |
Currently, when something goes wrong in `tx.CreateManager` such as invalid sql, the error returned is ignored. We should handle the error and return accordingly.
graham-chainlink
force-pushed
the
ggoh/handle-create-manager-error
branch
from
b56ce8f
to
57161d2
Compare
eutopian
approved these changes
Aug 22, 2024
gustavogama-cll
approved these changes
Aug 22, 2024
ro-tex
approved these changes
Aug 22, 2024
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when something goes wrong in
tx.CreateManagersuch as invalid sql constraint, the error returned is ignored. This PR checks the error returned fromtx.CreateManagerand return accordingly.