Update EstimateGasLimit config name to EstimateLimit #14297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangzhen1997
previously approved these changes
Sep 3, 2024
dimriou
reviewed
Sep 3, 2024
| @@ -559,7 +559,7 @@ type GasEstimator struct { | |||
| LimitMultiplier *decimal.Decimal | |||
| LimitTransfer *uint64 | |||
| LimitJobType GasLimitJobType `toml:",omitempty"` | |||
| EstimateGasLimit *bool | |||
| EstimateLimit *bool | |||
dimriou
reviewed
Sep 3, 2024
| @@ -92,7 +92,7 @@ func (g *TestGasEstimatorConfig) LimitTransfer() uint64 { return 42 } | |||
| func (g *TestGasEstimatorConfig) PriceMax() *assets.Wei { return assets.NewWeiI(42) } | |||
| func (g *TestGasEstimatorConfig) PriceMin() *assets.Wei { return assets.NewWeiI(42) } | |||
| func (g *TestGasEstimatorConfig) Mode() string { return "FixedPrice" } | |||
| func (g *TestGasEstimatorConfig) EstimateGasLimit() bool { return false } | |||
| func (g *TestGasEstimatorConfig) EstimateLimit() bool { return false } | |||
dimriou
reviewed
Sep 3, 2024
| @@ -531,7 +531,7 @@ func TestConfig_Marshal(t *testing.T) { | |||
| LimitMax: ptr[uint64](17), | |||
| LimitMultiplier: mustDecimal("1.234"), | |||
| LimitTransfer: ptr[uint64](100), | |||
| EstimateGasLimit: ptr(false), | |||
| EstimateLimit: ptr(false), | |||
|
I see you updated files related to
|
dimriou
previously approved these changes
Sep 3, 2024
jmank88
reviewed
Sep 3, 2024
.changeset/loud-windows-call.md
Outdated
| @@ -2,4 +2,4 @@ | |||
| "chainlink": minor | |||
| --- | |||
|
|
|||
| Added gas limit estimation feature to EVM gas estimators #added | |||
| Added gas limit estimation feature to EVM gas estimators. Introduced a new config EstimateLimit to toggle this feature. #added | |||
There was a problem hiding this comment.
Suggested change
| Added gas limit estimation feature to EVM gas estimators. Introduced a new config EstimateLimit to toggle this feature. #added | |
| Added gas limit estimation feature to EVM gas estimators. Introduced a new config `EVM.GasEstimator.EstimateLimit` to toggle this feature. #added |
dimriou
approved these changes
Sep 3, 2024
|
huangzhen1997
approved these changes
Sep 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
amit-momin
added a commit
that referenced
this pull request
Sep 3, 2024
* Updated EstimateGasLimit config name to EstimateLimit * Updated mocks * Fixed linting * Updated changeset
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Bump version and update CHANGELOG fore core v2.16.0 Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com> * Update EstimateGasLimit config name to EstimateLimit (#14297) * Updated EstimateGasLimit config name to EstimateLimit * Updated mocks * Fixed linting * Updated changeset * fix: goreleaser-build-sign-publish-chainlink workflow (#14139) * remove other gha workflows and test build-publish workflow * update cosigner gha and version * add env GORELEASER_KEY * add GITHUB_TOKEN env * temp add current_tag env * add --skip=validate temp * remove prev * skip release * use disable instead * fix post release publish bug * use keyless signing * revert and comment stdin * comment all cosign user/pass * add args to docker_signs * remove cosign user/pass env and uncomment other workflow * update cosign to keyless for regular docker build images * use keyless input and temp remove slack-notify * use image digest for signing * use --yes flag in cosign sign and update cosign-installer version * add --yes flag to cosign verify * fix typo and remove --yes * refactor to remove cosign keypair way and only use keyless signing * revert back deleted gha workflow files * refactor with suggestions * fix set env step * fix typos and naming * core/services/relay/evm: handle error from chainselectors * Fix pruning query * Add regression testing for pruning bug * Query exact wasmvm module rather than parsing all (#14425) * exclude sourcegraph missing dependency (#14446) * exclude sourcegrapht * use replace * finalize date on changelog for 2.16.0 * fix merge issues * another --------- Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com> Co-authored-by: chainchad <96362174+chainchad@users.noreply.github.com> Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com> Co-authored-by: Jordan Krage <jmank88@gmail.com> Co-authored-by: Domino Valdano <2644901+reductionista@users.noreply.github.com> Co-authored-by: HenryNguyen5 <6404866+HenryNguyen5@users.noreply.github.com> Co-authored-by: Sergey Kudasov <f4hrenh9it@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
EstimateGasLimitconfig name toEstimateLimitsince this config is under theGasEstimator.Gasis implied by the config section so there is no need to mention it in the config name.