Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPPL-20] Pass GatewayConnector to standard capability Delegate #14397

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[CAPPL-20] Pass GatewayConnector to standard capability Delegate #14397

merged 1 commit into from
Sep 11, 2024

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Sep 11, 2024

Add a placeholder for one of the new Web API capabilities.

bolekk
bolekk commented Sep 11, 2024
View reviewed changes
core/capabilities/gateway_connector/service_wrapper.go Outdated
@@ -0,0 +1,114 @@
package gateway_connector
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be rebased away

@bolekk bolekk force-pushed the feature/CAPPL-20-standard-cap-delegate branch 2 times, most recently from 12502ed to 8135bc4 Compare September 11, 2024 05:00
bolekk
bolekk commented Sep 11, 2024
View reviewed changes
core/capabilities/gateway_connector/service_wrapper.go Outdated
@@ -0,0 +1,114 @@
package gatewayconnector
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be rebased away

@bolekk bolekk force-pushed the feature/CAPPL-20-standard-cap-delegate branch from 8135bc4 to 83f34cf Compare September 11, 2024 14:11
bolekk
bolekk commented Sep 11, 2024
View reviewed changes
core/capabilities/gateway_connector/service_wrapper_test.go
@@ -1,4 +1,4 @@
package gatewayconnector
package gatewayconnector_test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to avoid an import cycle caused by application.go and core/services/chainlink

@bolekk bolekk marked this pull request as ready for review September 11, 2024 14:13
@bolekk bolekk requested a review from a team as a code owner September 11, 2024 14:13
@bolekk
[CAPPL-20] Pass GatewayConnector to standard capability Delegate
41b7654 
Add a placeholder for one of the new Web API capabilities.
@bolekk bolekk force-pushed the feature/CAPPL-20-standard-cap-delegate branch from 83f34cf to 41b7654 Compare September 11, 2024 14:20
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
2 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
18.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@bolekk bolekk added this pull request to the merge queue Sep 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@bolekk bolekk added this pull request to the merge queue Sep 11, 2024
Merged via the queue into develop with commit bfb66fa Sep 11, 2024
136 of 137 checks passed
@bolekk bolekk deleted the feature/CAPPL-20-standard-cap-delegate branch September 11, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidOrchard DavidOrchard DavidOrchard approved these changes

@DeividasK DeividasK DeividasK approved these changes

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@jinhoonbang jinhoonbang Awaiting requested review from jinhoonbang

@justinkaseman justinkaseman Awaiting requested review from justinkaseman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bolekk @DavidOrchard @DeividasK @cedric-cordenier