[CAPPL-40] Add custom compute capability #14496
Open
+760
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cedric-cordenier
commented
Sep 19, 2024
•
cedric-cordenier
commented
- Add a custom compute capability. Since this depends on gateway, I've added it to one of the special cases in the standard capabilities delegate.
cedric-cordenier
force-pushed
the
CAPPL-40-compute-capability
branch
8 times, most recently
from
359c8e4
to
05f2b71
Compare
cedric-cordenier
changed the title
cedric-cordenier
force-pushed
the
CAPPL-40-compute-capability
branch
from
05f2b71
to
1c73289
Compare
cedric-cordenier
requested review from
ilija42,
nolag,
justinkaseman and
ettec
and removed request for
a team
MStreet3
reviewed
Sep 24, 2024
cedric-cordenier
force-pushed
the
CAPPL-40-compute-capability
branch
2 times, most recently
from
8abc898
to
fe7219a
Compare
MStreet3
reviewed
Sep 24, 2024
MStreet3
reviewed
Sep 24, 2024
MStreet3
reviewed
Sep 24, 2024
cedric-cordenier
force-pushed
the
CAPPL-40-compute-capability
branch
2 times, most recently
from
b8d4bcf
to
84aaa4d
Compare
ettec
previously approved these changes
Sep 25, 2024
core/capabilities/compute/compute.go
Outdated
|
|
||
| id := generateID(binary) | ||
|
|
||
| m, err := c.modules.get(id) |
There was a problem hiding this comment.
nit: c.modules.get should use map like semantics (ie bool to indicate found) instead of an error
- Pass through binary + config through the workflow engine
cedric-cordenier
force-pushed
the
CAPPL-40-compute-capability
branch
from
8c86d12
to
6f2ad32
Compare
ettec
approved these changes
Sep 25, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.