[BCFR-147] - Add DecodeHook to convert between string and common.Address types #14508
+595
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Farber98
changed the title
Farber98
requested review from
RensR,
matYang,
RayXpub,
elatoskinas and
a team
as code owners
Farber98
requested review from
Atrax1,
ilija42,
silaslenihan and
EasterTheBunny
and removed request for
a team,
RensR,
matYang,
RayXpub,
elatoskinas and
Atrax1
EasterTheBunny
previously approved these changes
Sep 23, 2024
Comment on lines
+183
to
+184
| stringType, stringPtrType := reflect.TypeOf(""), reflect.PointerTo(reflect.TypeOf("")) | ||
| addressType, addressPtrType := reflect.TypeOf(common.Address{}), reflect.TypeOf(&common.Address{}) |
There was a problem hiding this comment.
These can be constants outside the function scope. This would save them being declared every time the function runs.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description:
Add an EVM exclusive modifier/hook that changes onchain common.Address type to string.
This PR:
Adds
addressStringDecodeHookto convert betweenstringandcommon.Addresstypes. It handles the following conversions:stringor*string->common.Addressor*common.Addresscommon.Addressor*common.Address->stringor*stringTicket: