Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHIP-2813] Align FinalityTagEnabled chain config between CCIP and Core #14530

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

[SHIP-2813] Align FinalityTagEnabled chain config between CCIP and Core #14530

wants to merge 5 commits into from
+62 −38

Conversation

Madalosso
Copy link
Contributor

Align FinaltyTagEnabled across all products SHIP-2813

This PR carries CCIP chain default configurations for FinalityTagEnabled and applies them to core configs.

@Madalosso
Copy link
Contributor Author

I'll trigger soak tests on three random networks to test this

@Madalosso Madalosso marked this pull request as ready for review September 23, 2024 18:53
@Madalosso Madalosso requested review from a team as code owners September 23, 2024 18:53
@Madalosso Madalosso requested review from vyzaldysanchez and removed request for a team September 23, 2024 18:53
@dimriou
Copy link
Collaborator

dimriou commented Sep 24, 2024

You need to run make config-docs to update CONFIG.md file

@Madalosso
Copy link
Contributor Author

@amit-momin thanks for your input, I've reordered the configs to match how they are displayed on the docs.

@Madalosso Madalosso force-pushed the SHIP-2813-Align-FinaltyTagEnabled-across-all-products branch 3 times, most recently from 25443da to 456a748 Compare September 24, 2024 18:13
Madalosso and others added 5 commits September 25, 2024 11:19
@Madalosso
set FinalityTagEnabled = true for testnets to match ccip config
f1cc921
@Madalosso
Same changes on mainnets
a717969
@Madalosso
Add changeset
685cbbc
@Madalosso
generate config docs
de82e91
@Madalosso @amit-momin
Apply suggestions from code review
b9d860f 
Thanks for suggestions, I'll accept and replicate

Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com>
@Madalosso Madalosso force-pushed the SHIP-2813-Align-FinaltyTagEnabled-across-all-products branch from 578651e to b9d860f Compare September 25, 2024 14:19
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez vyzaldysanchez is a code owner automatically assigned from smartcontractkit/foundations

@amit-momin amit-momin Awaiting requested review from amit-momin

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Madalosso @dimriou @amit-momin