Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keystone aptos scripts #14539

Merged
merged 15 commits into from
Sep 24, 2024
Merged

Keystone aptos scripts #14539

merged 15 commits into from
Sep 24, 2024

Conversation

archseer
Copy link
Contributor

@archseer archseer commented Sep 24, 2024

NodeKeys.txt format is slightly changed, by adding one extra column: we now support both a local url (used to talking to the node via API) and a remote url (DNS address reachable within a node)

@archseer archseer requested a review from a team September 24, 2024 09:04
@archseer archseer requested a review from a team as a code owner September 24, 2024 09:04
@archseer archseer requested review from EasterTheBunny and removed request for a team September 24, 2024 09:04
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

smickovskid
smickovskid previously approved these changes Sep 24, 2024
@archseer archseer added this pull request to the merge queue Sep 24, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Merged via the queue into develop with commit 8905e88 Sep 24, 2024
126 of 127 checks passed
@archseer archseer deleted the keystone-aptos-scripts branch September 24, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants