Functions Router #9365
Functions Router #9365
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
Go solidity wrappers are out-of-date, regenerate them via the |
justinkaseman
force-pushed
the
jk/functions-router-simple
branch
from
ac97761
to
0ad5934
Compare
|
Go solidity wrappers are out-of-date, regenerate them via the |
justinkaseman
force-pushed
the
jk/functions-router-simple
branch
from
0ad5934
to
9c867af
Compare
|
Go solidity wrappers are out-of-date, regenerate them via the |
2 similar comments
|
Go solidity wrappers are out-of-date, regenerate them via the |
|
Go solidity wrappers are out-of-date, regenerate them via the |
justinkaseman
force-pushed
the
jk/functions-router-simple
branch
from
e5bcec4
to
d84ad07
Compare
|
Go solidity wrappers are out-of-date, regenerate them via the |
2 similar comments
|
Go solidity wrappers are out-of-date, regenerate them via the |
|
Go solidity wrappers are out-of-date, regenerate them via the |
contracts/src/v0.8/functions/dev/1_0_0/FunctionsCoordinator.sol
Outdated
Show resolved
Hide resolved
|
Go solidity wrappers are out-of-date, regenerate them via the |
There was a problem hiding this comment.
These are my comments so far. I started to become confused while reviewing FunctionsSubscriptions.sol.
I still need to complete reviewing /tests/, */1_0_0/FunctionsBilling.sol, */1_0_0/FunctionsClient.sol, */1_0_0/FunctionsCoordinator.sol, */1_0_0/FunctionsRouter.sol and */1_0_0/FunctionsSubscriptions.sol
contracts/src/v0.8/functions/dev/1_0_0/accessControl/AuthorizedOriginReceiver.sol
Show resolved
Hide resolved
contracts/src/v0.8/functions/dev/1_0_0/accessControl/AuthorizedOriginReceiver.sol
Show resolved
Hide resolved
contracts/src/v0.8/functions/dev/1_0_0/accessControl/AuthorizedOriginReceiver.sol
Show resolved
Hide resolved
contracts/src/v0.8/functions/dev/1_0_0/example/FunctionsClientExample.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/functions/dev/1_0_0/example/FunctionsClientExample.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/functions/dev/1_0_0/FunctionsSubscriptions.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/functions/dev/1_0_0/FunctionsSubscriptions.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/functions/dev/1_0_0/FunctionsSubscriptions.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
These are my comments so far. I started to become confused while reviewing FunctionsSubscriptions.sol.
I still need to complete reviewing /tests/, */1_0_0/FunctionsBilling.sol, */1_0_0/FunctionsClient.sol, */1_0_0/FunctionsCoordinator.sol, */1_0_0/FunctionsRouter.sol and */1_0_0/FunctionsSubscriptions.sol
|
Go solidity wrappers are out-of-date, regenerate them via the |
justinkaseman
force-pushed
the
jk/functions-router-simple
branch
from
c1c7bcb
to
d727bac
Compare
|
Go solidity wrappers are out-of-date, regenerate them via the |
contracts/src/v0.8/functions/dev/1_0_0/FunctionsSubscriptions.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/functions/dev/1_0_0/interfaces/IFunctionsBilling.sol
Outdated
Show resolved
Hide resolved
|
Go solidity wrappers are out-of-date, regenerate them via the |
|
Go solidity wrappers are out-of-date, regenerate them via the |
justinkaseman
force-pushed
the
jk/functions-router-simple
branch
from
8a1d7cf
to
5d13fe4
Compare
|
Go solidity wrappers are out-of-date, regenerate them via the |
1 similar comment
|
Go solidity wrappers are out-of-date, regenerate them via the |
justinkaseman
force-pushed
the
jk/functions-router-simple
branch
from
5acd776
to
4ec024e
Compare
| Location codeLocation; | ||
| Location secretsLocation; // Only Remote secrets are supported | ||
| CodeLanguage language; | ||
| string source; // Source code for Location.Inline, url for Location.Remote or slot decimal number for Location.DONHosted |
There was a problem hiding this comment.
This must be my bad, but we shall repeat the logic for source regarding DONHosted variant.
Maybe we can even add the same helper addDONHostedSource()
| Location secretsLocation; // Only Remote secrets are supported | ||
| CodeLanguage language; | ||
| string source; // Source code for Location.Inline, url for Location.Remote or slot decimal number for Location.DONHosted | ||
| bytes encryptedSecretsReference; // Encrypted urls for Location.Remote or CBOR encoded slotid+version for Location.DONHosted, use addDONHostedSecrets() |
There was a problem hiding this comment.
@KuphJr since DONHosted option does not use encryption, shall we rename this field to be just secretsReference?
There was a problem hiding this comment.
Well, the DONHosted secrets are technically encrypted, so I think the name still works?
| /** | ||
| * @notice Uses current price feed data to estimate a cost | ||
| */ | ||
| function _calculateCostEstimate( |
There was a problem hiding this comment.
What are we gonna do about the problem of an increase in gas price between time of request and time of response? Should we add an overestimate percentage for gas price or something? This could be a config variable.
justinkaseman
force-pushed
the
jk/functions-router-simple
branch
from
636143e
to
cd6e702
Compare
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
No description provided.