[Functions] Mark duplicate request ID log as consumed

[bolekk]

Do it to avoid a flood of repetitive error when LogBroadcaster re-submits the same log in a loop.

[github-actions]

I see that you haven't updated any README files. Would it make sense to do so?

[reductionista]

Not sure off the top of my head, but one thing you could improve about this is instead of require.True use:
require.ErorrIs(t, err, functions.ErrDuplicateRequestID)

That will print the actual and expected errors so you can compare, instead of just "Should be true" if it fails.

[reductionista]

Oh I see what the problem is... you're looking for 2 sql errors in a row to happen, but that can never happen in tests. The tests run in a special mode where everything is wrapped inside a single transaction. So you can never get more than one error... all queries after the first error will fail with error message "transaction is aborted".

[pinebit]

This approach seems very fragile to me.
Why not do insert into ... on conflict (request_id) do nothing, then you check affected rows count returned from Exec(). If the count is zero, then you had a conflict.
@reductionista do you agree?

[bolekk]

But then if Exec fails for another reason (e.g. context expired) the row count will be zero as well, right? I want to differentiate a duplicate ID specifically. Another way is to have a transaction with a GET first and then INSERT later.

[pinebit]

The err will not be nil, this is how you differentiate.

[pinebit]

func (o *orm) CreateRequest(requestID RequestID, receivedAt time.Time, requestTxHash *common.Hash, qopts ...pg.QOpt) error {
	stmt := `
		INSERT INTO ocr2dr_requests (request_id, contract_address, received_at, request_tx_hash, state)
		VALUES ($1,$2,$3,$4,$5) ON CONFLICT (request_id) DO NOTHING;
	`
	result, err := o.q.WithOpts(qopts...).Exec(stmt, requestID, o.contractAddress, receivedAt, requestTxHash, IN_PROGRESS)
	if err != nil {
		return err
	}
	nrows, err := result.RowsAffected()
	if err != nil {
		return err
	}
	if nrows == 0 {
		return ErrDuplicateRequestID
	}
	return nil
}

[bolekk]

I see, thanks! I'll change to the suggested approach.

[cl-sonarqube-production]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

90.0% Coverage
0.0% Duplication