Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up some logging #9675

Merged
merged 2 commits into from
Jun 23, 2023
Merged

clean up some logging #9675

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b2ef78
clean up some logging
samsondav Jun 21, 2023
c3aa8dd
Merge branch 'develop' into minor_debugging_improvements
samsondav Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/chains/evm/logpoller/log_poller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func NewLogPoller(orm *ORM, ec Client, lggr logger.Logger, pollPeriod time.Durat
return &logPoller{
ec: ec,
orm: orm,
lggr: lggr,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it didn't use to log the name of the service, it logs it now, that's what I'm trying to fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I must be dyslexic or something... somehow saw the change as removing rather than adding! Looks good

lggr: lggr.Named("LogPoller"),
replayStart: make(chan int64),
replayComplete: make(chan error),
pollPeriod: pollPeriod,
Expand Down
2 changes: 1 addition & 1 deletion core/services/relay/evm/mercury/transmitter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ func (mt *mercuryTransmitter) Transmit(ctx context.Context, reportCtx ocrtypes.R
Payload: payload,
}

mt.lggr.Debugw("Transmit enqueue", "req", req, "report", report, "reportCtx", reportCtx, "signatures", signatures)
mt.lggr.Tracew("Transmit enqueue", "req", req, "report", report, "reportCtx", reportCtx, "signatures", signatures)

if ok := mt.queue.Push(req, reportCtx); !ok {
return errors.New("transmit queue is closed")
Expand Down