Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functions] Basic handler #9709

Merged
merged 1 commit into from
Jul 12, 2023
Merged

[Functions] Basic handler #9709

merged 1 commit into from
Jul 12, 2023

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Jun 23, 2023 •
edited
Loading

  1. Support Set and List methods.
  2. Add a generic RequestCache type.

@bolekk bolekk requested a review from pinebit June 23, 2023 02:40
@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@bolekk bolekk force-pushed the feature/FUN-645-s4-handler branch from 2478dcd to e8947d6 Compare June 23, 2023 02:57
@pinebit
Copy link
Contributor

pinebit commented Jun 30, 2023

This work appears to be the last piece we need to start testing the full integration?

@bolekk bolekk force-pushed the feature/FUN-645-s4-handler branch 2 times, most recently from b10cbec to f67b529 Compare July 11, 2023 05:29
pinebit
pinebit reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bolekk bolekk force-pushed the feature/FUN-645-s4-handler branch from f67b529 to c5f3aca Compare July 12, 2023 04:26
@bolekk bolekk marked this pull request as ready for review July 12, 2023 04:27
@bolekk bolekk force-pushed the feature/FUN-645-s4-handler branch from c5f3aca to 693bf74 Compare July 12, 2023 05:15
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 75.2% 75.2% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@bolekk bolekk added this pull request to the merge queue Jul 12, 2023
Merged via the queue into develop with commit bfc91ea Jul 12, 2023
@bolekk bolekk deleted the feature/FUN-645-s4-handler branch July 12, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinebit pinebit pinebit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bolekk @pinebit