[BCF-2261] Remove evm/config/v2; replace with evm/config and evm/config/toml. #9753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
cedric-cordenier
force-pushed
the
bcf-2261-rename-evm-config
branch
from
db15a8a
to
317c177
Compare
cedric-cordenier
changed the title
cedric-cordenier
requested review from
jkongie,
jmank88,
samsondav,
a team,
connorwstein and
prashantkumar1982
as code owners
jmank88
approved these changes
Jul 11, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core/chains/evm/configandcore/chains/evm/config/v2to remove the versioning. There are now two new packages instead:core/chains/evm/configcontains the config interface, and its concrete chain scoped implementation, andcore/chains/evm/config/tomlcontains the TOML struct types.