Full integration of threshold plugin with Functions #9765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KuphJr
commented
Jul 10, 2023
•
KuphJr
commented
- Completed integration of threshold plugin with Functions
- Added Functions integration tests with threshold decryption
KuphJr
requested review from
a team,
bolekk,
justinkaseman and
pinebit
as code owners
|
I see that you haven't updated any README files. Would it make sense to do so? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| res.WriteHeader(http.StatusOK) | ||
| // prepend "0xab" to source and return as result | ||
| _, err = res.Write([]byte(fmt.Sprintf(`{"result": "success", "statusCode": 200, "data": {"result": "0xab%s", "error": ""}}`, source))) | ||
| _, err = res.Write(responsePayload) |
Check warning
Code scanning / CodeQL
Reflected cross-site scripting
bolekk
requested changes
Jul 11, 2023
core/services/ocr2/plugins/functions/integration_tests/internal/testutils.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/functions/integration_tests/internal/testutils.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/functions/integration_tests/functions_integration_test.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/functions/integration_tests/functions_integration_test.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/functions/integration_tests/functions_integration_test.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/functions/integration_tests/internal/testutils.go
Outdated
Show resolved
Hide resolved
|
SonarQube Quality Gate
|
bolekk
approved these changes
Jul 11, 2023
| for i := 0; i < nOracleNodes; i++ { | ||
| var thresholdKeyShare string | ||
| if len(thresholdKeyShares) == 0 { | ||
| thresholdKeyShare = "" |
| require.Equal(t, functions.LanguageJavaScript, int(data["language"].(float64))) | ||
| require.Equal(t, functions.LocationInline, int(data["codeLocation"].(float64))) | ||
| require.Equal(t, functions.LocationRemote, int(data["secretsLocation"].(float64))) | ||
| if data["secrets"] != DefaultSecretsBase64 && request["nodeProvidedSecrets"] != fmt.Sprintf(`{"0x0":"%s"}`, DefaultSecretsBase64) { |
There was a problem hiding this comment.
This is hard to understand without remembering how the legacy flow works exactly. I hope we can simplify after everything is migrated to Threshold.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.