Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set FeedID in delegate's logger only if non-zero #9801

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Set FeedID in delegate's logger only if non-zero #9801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions core/services/ocr2/delegate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,14 +308,13 @@ func (d *Delegate) ServicesForSpec(jb job.Job) ([]job.ServiceCtx, error) {
JobName: jb.Name.ValueOrZero(),

ContractID: spec.ContractID,
FeedID: spec.FeedID,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmank88 your fix in relayers didn't solve it because feedID is never nil

TransmitterID: transmitterID,
}
lggr := logger.Sugared(d.lggr.Named("OCR2").With(lggrCtx.Args()...))

if spec.FeedID != (common.Hash{}) {
lggrCtx.FeedID = spec.FeedID
spec.RelayConfig["feedID"] = spec.FeedID
}
lggr := logger.Sugared(d.lggr.Named("OCR2").With(lggrCtx.Args()...))

if spec.Relay == relay.EVM {
chainID, err2 := spec.RelayConfig.EVMChainID()
Expand Down