-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cache ttl refresh on heartbeat message for Finnhub #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67d846e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Soak test for finnhub succeeded
✔️ Assertions loaded: 1, applied: 1
Output sample
|
karen-stepanyan
force-pushed
the
feature/DF-19693
branch
from
April 8, 2024 12:38
249ecee
to
a875732
Compare
✔️ Soak test for finnhub succeeded
✔️ Assertions loaded: 1, applied: 1
Output sample
|
karen-stepanyan
force-pushed
the
feature/DF-19693
branch
from
April 8, 2024 13:00
a875732
to
0f489f4
Compare
✔️ Soak test for finnhub succeeded
✔️ Assertions loaded: 1, applied: 1
Output sample
|
✔️ Soak test for finnhub succeeded
✔️ Assertions loaded: 1, applied: 1
Output sample
|
alecgard
approved these changes
Apr 22, 2024
✔️ Soak test for finnhub succeeded
✔️ Assertions loaded: 1, applied: 1
Output sample
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DF-19693
Added new check in Finnhub EA's Price WS transport that checks if the incoming WS message is a heartbeat message (usually once every 60 seconds) and tries to update the TTL of the forex cache entries from active subscription set.
Heartbeat message looks like this
This ensures that as long as there is an active request to EA (in subscription set) and cached entry and heartbeat message from DP, the EA will persist the cache so that the value is available during off-market hours.
Forex entries are identified by checking the NEW
endpointName
input param value, which is set automatically based on the rawendpoint
property in the request data.This means that the request MUST contain 'endpoint: forex'
Applies to Finnhub and Finnhub-Secondary EAs