-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new DLC-BTC-POR EA #3275
Added new DLC-BTC-POR EA #3275
Conversation
🦋 Changeset detectedLatest commit: 99d181f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Feedback is mostly just for some extra context to be added in comments
packages/sources/dlc-btc-por/src/transport/proof-of-reserves.ts
Outdated
Show resolved
Hide resolved
packages/sources/dlc-btc-por/src/transport/proof-of-reserves.ts
Outdated
Show resolved
Hide resolved
packages/sources/dlc-btc-por/src/transport/proof-of-reserves.ts
Outdated
Show resolved
Hide resolved
packages/sources/dlc-btc-por/src/transport/proof-of-reserves.ts
Outdated
Show resolved
Hide resolved
packages/sources/dlc-btc-por/src/transport/proof-of-reserves.ts
Outdated
Show resolved
Hide resolved
packages/sources/dlc-btc-por/src/transport/proof-of-reserves.ts
Outdated
Show resolved
Hide resolved
Looks good, I think the main worries are batching/upper limit testing and further chain expansion, but these shouldn't be immediate issues. Worst case we can discuss & handle in future sprints. |
18dfe61
cbb241b
to
18dfe61
Compare
Did some upper limit tests 5000 transaction checks (5 different transaction duplicated 1000 times) 5000 transaction checks (5 different transaction duplicated 1000 times) From my testing the RPC was able to handle 70 concurrent requests, depending on RPC and network latency maybe this is not the limit. In terms of overall time execution we also need to have some space for a EVM RPC call to get the vaults |
Closes DF-19884
Description
Added new DLC-BTC-POR source EA. The EA doesn't take any input params. It fetches a list of vaults from a contract and for each vault verifies the vault deposit balance and sums all verified balances.
Steps to Test
yarn test packages/sources/dlc-btc-por
Quality Assurance
infra-k8s
configuration file.adapter-secrets
configuration file or update the soak testing blacklist.test-payload.json
file with relevant requests.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Jira.