Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new DLC-BTC-POR EA #3275

Merged
merged 12 commits into from
May 1, 2024
Merged

Added new DLC-BTC-POR EA #3275

merged 12 commits into from
May 1, 2024

Conversation

karen-stepanyan
Copy link
Contributor

@karen-stepanyan karen-stepanyan commented Apr 23, 2024

Closes DF-19884

Description

Added new DLC-BTC-POR source EA. The EA doesn't take any input params. It fetches a list of vaults from a contract and for each vault verifies the vault deposit balance and sums all verified balances.

Steps to Test

yarn test packages/sources/dlc-btc-por

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented Apr 23, 2024

🦋 Changeset detected

Latest commit: 99d181f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/dlc-btc-por-adapter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@alecgard alecgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Feedback is mostly just for some extra context to be added in comments

alecgard
alecgard previously approved these changes Apr 24, 2024
@mmcallister-cll
Copy link
Contributor

Looks good, I think the main worries are batching/upper limit testing and further chain expansion, but these shouldn't be immediate issues. Worst case we can discuss & handle in future sprints.

@karen-stepanyan
Copy link
Contributor Author

Did some upper limit tests
10000 transaction checks (5 different transaction duplicated 2000 times)
70 concurrent requests to BITCOIN_RPC
took 2 minutes 16 seconds

5000 transaction checks (5 different transaction duplicated 1000 times)
30 concurrent requests to BITCOIN_RPC
took 2 minutes 24 seconds

5000 transaction checks (5 different transaction duplicated 1000 times)
50 concurrent requests to BITCOIN_RPC
took 1 minute 29 seconds

From my testing the RPC was able to handle 70 concurrent requests, depending on RPC and network latency maybe this is not the limit. In terms of overall time execution we also need to have some space for a EVM RPC call to get the vaults

mmcallister-cll
mmcallister-cll previously approved these changes May 1, 2024
@karen-stepanyan karen-stepanyan merged commit dca5e7d into main May 1, 2024
8 checks passed
@karen-stepanyan karen-stepanyan deleted the feature/DF-19884 branch May 1, 2024 11:44
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants