Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blocksize-capital provider indicated timestamp #3382

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

austinborn
Copy link
Contributor

@austinborn austinborn commented Aug 9, 2024

Closes DF-20302

Description

Patch Blocksize Capital adapter to ensure it sends correct units for providerIndicatedTimestampMs for the cryptolwba endpoint. Note that this is the only endpoint that returns microseconds whereas the others return milliseconds.

Steps to Test

yarn && yarn setup && yarn test packages/sources/blocksize-capital/test/integration/*

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: b881c92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@chainlink/blocksize-capital-adapter Patch
@chainlink/token-allocation-adapter Patch
@chainlink/apy-finance-adapter Patch
@chainlink/bsol-price-adapter Patch
@chainlink/crypto-volatility-index-adapter Patch
@chainlink/curve-3pool-adapter Patch
@chainlink/defi-dozen-adapter Patch
@chainlink/defi-pulse-adapter Patch
@chainlink/dxdao-adapter Patch
@chainlink/linear-finance-adapter Patch
@chainlink/savax-price-adapter Patch
@chainlink/set-token-index-adapter Patch
@chainlink/synth-index-adapter Patch
@chainlink/vesper-adapter Patch
@chainlink/xsushi-price-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@austinborn austinborn merged commit f8133f8 into main Aug 9, 2024
7 of 8 checks passed
@austinborn austinborn deleted the feature/DF-20302 branch August 9, 2024 18:18
@github-actions github-actions bot mentioned this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants