Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/DF-20368 combine tp and icap #3449

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mmcallister-cll
Copy link
Contributor

@mmcallister-cll mmcallister-cll commented Sep 28, 2024

Closes #DF-20368

Description

  • Combining TP and ICAP EAs

Changes

  • Removed icap dir
  • added query param selector for streamName (ie: last 2 chars of asset name in the format CEFWDXAUUSDSPT02Y:LDN.BIL.QTE.RTM!TP)
  • updated cache to add streamName param to key

Still Left

  • Add existing tests from icap to tp with selector
  • Determine what to do with CAD/USD includes (only difference between includes files)
  • E2E testing during market hours

Steps to Test

  1. yarn test tp/test
  2. regression on forex endpoint using url:8080?streamName=TP and url:8080?streamName=IC

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented Sep 28, 2024

🦋 Changeset detected

Latest commit: 56fb9b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/tp-adapter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant