elwood: check subscriptions before sending subscribe requests #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: df6389c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alecgard
reviewed
Sep 30, 2024
alecgard
previously approved these changes
Sep 30, 2024
alecgard
approved these changes
Sep 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack context: https://chainlink-core.slack.com/archives/C0290SGU1KR/p1727513673689309
All Elwood connections sharing the same API key will have the same set of subscriptions, e.g. if there are multiple EAs using the same key. To avoid overloading Elwood's servers, we should only add new subscriptions if the current set of subscriptions does not have it. Similarly, we should stop unsubscribing as there is no way to know if another EA needs the asset or not.
This PR adds an API call to first fetch the set of subscribed items and filters the subscribe messages for new ones. It also ignores unsubscribe messages.
Example logs from local server: