fix(deps): update dependencies

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
Google.Protobuf	3.28.2 -> 3.28.3
Roslynator.Analyzers	4.10.0 -> 4.12.9
SonarAnalyzer.CSharp (source)	9.19.0.84025 -> 9.32.0.97167

---

Release Notes

dotnet/roslynator (Roslynator.Analyzers)

v4.12.9

Fixed

• Fix analyzer RCS1090 (PR)
• Fix analyzer RCS1124 (PR)
• [CLI] Fix command generate-doc (PR, PR)

Changed

• Update analyzer RCS1077 (PR)
  • Do not suggest to change list.FirstOrDefault(predicate) to list.Find(predicate).
    Performance gain is negligible and actually FirstOrDefault can be even faster on .NET 9 (see related issue for more details).

v4.12.8

Fixed

• Fix analyzer RCS0053 (PR)
• Fix analyzer RCS1223 (PR)
• Fix analyzer RCS1140 (PR)
• Fix analyzer RCS1096 (PR)
• [CLI] Improve removing of unused symbols (PR)
• [CLI] Fix command generate-doc (PR)

v4.12.7

Fixed

• Fix analyzer RCS1202 (PR)
• Fix analyzer RCS1246 (PR)
• Fix analyzer RCS1140 (PR)
• Fix analyzer RCS1077 (PR)

Changed

• Add support for duck-typed awaitables and task-like types for Task/Async-related analyzers (PR)
  • Affects the following analyzers:
    • RCS1046
    • RCS1047
    • RCS1090
    • RCS1174
    • RCS1229
    • RCS1261
  • Affects refactoring RR0209

v4.12.6

Added

• Analyzer RCS1077 now suggests to use Order instead of OrderBy (PR)

Fixed

• Fix analyzer RCS0053 (PR)
• Fix analyzer RCS0056 (PR)
• Fix analyzer RCS1181 (PR)
• Fix analyzer RCS0005 (PR)
• Fix analyzer RCS1181 (PR)

v4.12.5

Fixed

• Fix analyzer RCS1182 (PR)
• Fix analyzer RCS1198 (PR)
• Fix analyzer RCS1214 (PR)
• Fix analyzer RCS1018 (PR)
• Fix analyzer RCS1264 (PR)
• Fix analyzer RCS0053 (PR)
• Fix analyzer RCS0056 (PR)

Changed

• Bump Roslyn to 4.11.0 (PR)
  • Applies to CLI and testing library.

Removed

• [CLI] Remove support for .NET SDK 6 (PR)

v4.12.4

Fixed

• Fix analyzer RCS1108 (PR)
• Fix analyzer RCS1201 (PR)
• Fix analyzer RCS0012 (PR)
• [CLI] Fix duplicate analyzers (PR)

v4.12.3

Fixed

• Fix analyzer RCS1246 (PR)
• Fix analyzer RCS1085 (PR)
• Fix analyzer RCS1077 (PR)
• [CLI] Fix roslynator analyze --include/--exclude (PR)
• Fix analyzer RCS0036 (PR)

v4.12.2

Fixed

• [CLI] Fix loading of slnf files (PR)
• [CLI] Fix --severity-level (PR)
• Fix analyzer RCS1246 (PR)

v4.12.1

Changed

• [CLI] Bump Roslyn to 4.9.2 (PR)
• Convert Last() to [] (RCS1246) (PR)

Fixed

• Fix analyzer RCS1077 (PR)
• Fix export of ILanguageService (PR)

v4.12.0

Added

• Add analyzer "Simplify numeric comparison" RCS1268 (PR by @​jakubreznak)

Fixed

• Fix analyzer RCS1267 (PR)
• Fix "Unknown value 'Default'" exception (PR)
• Fix name of UnityEngine.SerializeField attribute (PR)
• Fix analyzer RCS1077 (PR)

v4.11.0

Added

• Add analyzer "Use raw string literal" RCS1266 (PR)
• Add analyzer "Convert 'string.Concat' to interpolated string" RCS1267 (PR)
• Simplify LINQ query RCS1077 (PR)
  • items.Select(selector).Average() => items.Average(selector)
  • items.Select(selector).Sum() => items.Sum(selector)

Fixed

• Fix analyzer RCS0049 (PR)
• Fix analyzer RCS1159 (PR)
• Fix analyzer RCS1019 (PR)
• Fix analyzer RCS1250 (PR, PR)
• Fix code fix for CS8600 changing the wrong type when casts or var are involved (PR by @​jroessel)
• Fix Roslyn multi-targeting (PR)

SonarSource/sonar-dotnet (SonarAnalyzer.CSharp)

v9.32.0.97167: 9.32

Compare Source

This rule includes the promotion of 4 rules to Sonar-way, the deprecation of 1 rule and 2 FP fixes.

Rule Promotions and Deprecations

• 9644 - Modify S2387: Deprecate rule
• 9643 - Modify S4050: Promote to Sonar-way
• 9642 - Modify S2674: Promote to Sonar-way
• 9641 - Modify S3993: Promote to Sonar-way
• 9640 - Modify S4052: Promote to Sonar-way

False Positive

• 9590 - [C#] Fix S6966 FP: EntityFrameworks IDbContextFactory CreateDbContext method is preferred over its Async counterpart
• 8300 - [C#] Fix S3431 FP: Don't raise if assertions are done in catch or finally

v9.31.0.96804: 9.31

Compare Source

This release focuses on improving the SonarQube plugin for the .NET analyzers.

Improvements

• 9558 - SQ Plugin: Load STIG standard after ACOMMONS-11 is done
• 8503 - SQ Plugin: Align logging for not indexed files
• 7798 - SQ Plugin: Remove the sonar runtime checks for versions prior 9.9
• 7115 - SQ Plugin: Replace org.sonar.api.utils.log.Logger
• 4687 - SQ Plugin: Add xunit report paths in products UI
• 4685 - SQ Plugin: Remove deprecated import of integration test coverage from plugins
• 3102 - SQ Plugin: Replace usages of deprecated Build.setProfile in the integration tests
• 8032 - SQ Plugin: Update the plugin to store the hash for the .cshtml files to enable incremental PR analysis

v9.30.0.95878: 9.30

Compare Source

Hello, everyone. In this release, we worked on hardening our live variable analysis, which improved the analyzer's accuracy.

False Positives

• 9473 - Fix S1854 FP: Raises when a variable is reassigned in a using body after it has been already assigned in using statement
• 9472 - Fix S1854 FP: Raises when a variable is assigned in the switch statement and not used in the first case
• 9471 - Fix S1854 FP: Raises when a variable is assigned in expression that is part of the ternary condition
• 9468 - Fix S1854 FP: Throw should connect to outer catch
• 9466 - Fix S1854 FP: Throw should visit finally

v9.29.0.95321: 9.29

Compare Source

This release includes a lot of false positive and false negative fixes.

Improvements

• 2120 - [C#] Improve S3247: Rule should recommend pattern matching for new C# instead of as
• 9465 - Update RSPEC before 9.29 release

False Positive

• 7522 - [C#] Fix S1104 FP: Do not report in Unity3D serializable classes
• 6990 - [C#] Fix S1144 FP: Event with a concrete sender
• 3842 - [C#] Fix S1144 FP: Ignore unused Deconstruct methods
• 8239 - [C#] Fix S1450 FP: When field is assigned value in event handler
• 9494 - [C#] Fix S1694 FP: Abstract class with field or constructor
• 9421 - [C#] Fix S1694 FP: Protected abstract methods
• 3605 - [C#] Fix S2219 FP: Is operator used for pattern matching
• 8266 - [C#] Fix S2259 FP: SE engine doesn't take into account element existence collection methods
• 9485 - [C#] Fix S3247 FP: Should not report on member access objects
• 6343 - [C#] Fix S3963 FP: Static constructor with conditional and no static field initialization
• 7961 - [C#, VB.NET] Fix S2699 FP: Support Moq

False Negative

• 9491 - [C#] Fix S3247 FN: When cast expression contains parentheses
•   223 - [C#] Fix S3247 FN: Rule should catch more duplicated cast

v9.28.0.94264: 9.28

Compare Source

False Positive

• 9432 - [C#] Fix S1144 FP: Unused fields in class with StructLayout when struct is in deep hierarchy class
• 9379 - [C#] Fix S1144 FP: Diagnostic doesn't respect reflection with DynamicallyAccessedMembers attribute
• 8342 - [C#] Fix S1144 FP: Private Attributes
• 7068 - [C#] Fix S4144 FP: when type constraints are used
• 3050 - [C#] Fix S1479 FP: Single line case clause should be ignored
• 9447 - [C#] Fix S1854 FP: Value used in catch or when should LiveIn for all try blocks
• 9440 - [C#] Fix S1854 FP: Value used in finally should LiveIn for all try blocks
• 4948 - [C#] Fix S1854 FP: Value used in finally should LiveIn after throw
• 6894 - [C#, VB.NET] Fix S3878 FP: When non-object array is passed to object[] params as first argument
• 6893 - [C#, VB.NET] Fix S3878 FP: when a params argument is named

False Negative

• 8719 - [C#, VB.NET] Fix S2583/S2589 FN: try-catch in loop, LVA purges symbol prematurely
• 4940 - [C#] Fix S1854 FN: Proper support of try/catch statements
• 1255 - [C#] Fix S1871 FN: Support single line conditional block

v9.27.0.93347: 9.27

Compare Source

This release includes a ton of false positive and false negative fixes. We would also like to thank @​sagi1623 for his contribution in #​8464, which fixed three issues 🚀.

Improvements

• RSPEC change - Rule S1694: Promoted to SonarWay
• 9390 - Rule S6608: Benchmark is benchmarking the wrong things
• 8795 - [C#] Improve S1694: Remove part about protected constructor
• 5417 - Enable multiple project level issues
• 9372 - Update RSPEC before 9.27 release

False Positive

• 9247 - [C#] Fix S2629 FP: Constant fields in interpolated string
• 9241 - [C#, VB.NET] Fix S2094 FP: Allow empty queries
• 9106 - [C#] Fix S3459 FP: Backing field with ref property
• 8522 - [C#, VB.NET] Fix S3220 FP: Rule does not take into account generics
• 8436 - [C#] Fix S3253 FP: Don't raise for primary constructor in type declarations without parameters when they inherit from types with parameters
• 8199 - [C#, VB.NET] Fix S2737 FP: Raised when exception filter is used
• 8025 - [C#] Fix S2325 FP: Partial method implementations
• 7521 - [C#] Fix S2743 FP: Should not raise when base type is generic
• 7137 - [VB.NET] Fix S1654 FP: Do not report on event handlers, interfaces and overrides

False Negative

• 9002 - [C#, VB.NET] Fix S6931 FN: Route templates starting with ~/
• 6644 - [C#] Fix S2190 FN: No issues raised if recursion is inside an EventDeclaration by @​sagi1623
• 6643 - [C#] Fix S2190 FN: No issues raised if recursion is inside a ConversionOperatorDeclaration by @​sagi1623
• 6642 - [C#] Fix S2190 FN: No issues raised if recursion is inside an indexer by @​sagi1623
• 4081 - [C#] Fix S2743 FN: Static fields of nested class inside generic class

v9.26.0.92422: 9.26

Compare Source

New Rules

• 8871 - [C#] New rule S6932: Use model binding instead of reading raw request data
• 8992 - [C#] New rule S4347: Secure random number generators must not output predictable values
• 8996 - [C#] New rule S6781: JWT secret keys should not be disclosed
• 8982 - [C#] New rule S6377: XML signatures should be verified securely
• 8998 - [C#] New rule S5344: Passwords should not be stored in plain-text or with a fast hashing algorithm

Bug Fixes

• 8577 - Fix S2234 Bug: AD0001 is thrown due to referencing a location outside of the current compilation

Improvements

• 9282 - [C#] S6964: Issue is reported on the attribute instead of the property

False Positive

• 9360 - [C#] Fix S6964 FP: Properties decorated with the [BindNever] attribute
• 9337 - [C#] Fix S6964 FP: Add more attributes to the exclusions
• 9336 - [C#] Fix S6966 FP: Don't raise on XmlReader and XmlWriter methods
• 9331 - [C#] Fix S6964 FP: Property with a default value
• 9285 - [C#] Fix S6964 FP: Do not raise in properties with required modifier
• 9284 - [C#] Fix S6964 FP: Should not raise for reference properties in nullable context
• 9275 - [C#] Fix S6964 FP: Don't raise on properties annotated with the JsonRequiredAttribute
• 9269 - [C#] Fix S6966 FP: EntityFrameworks DbContext/DBSet Add/AddRange methods are preferred over their Async counterpart
• 9265 - [C#] Fix S6966 FP: MongoDB Find can not be replaced by FindAsync
• 9252 - [C#] Fix S6934 FP: Abstract Controller base class
• 8985 - [C#] Fix S6934 FP: Attributes implementing IRouteTemplateProvider or inheriting from RouteAttribute

False Negative

• 9263 - [C#] Fix S6964 FN: Rule should raise in case of value type property annotated with RequiredAttribute

v9.25.1.91650: 9.25.1

Compare Source

The latest Roslyn compiler version changes the way Razor files are compiled, and this hotfix release takes care of these changes. For more information check this issue.

Bug Fixes

• 9288 - [C#] Metrics analyzer for Razor: Lines of code are outside the range of the file

v9.25.0.90414: 9.25

Compare Source

Hello everyone,

This release comes with seven new rules for ASP.NET core alongside some improvements.
Enjoy!

New Rules

• 9096 - [C#] New Rule S6966: Awaitable method should be used
• 9095 - [C#] New Rule S6967: ModelState.IsValid should be called in controller actions
• 9094 - [C#] New Rule S6964: The value type properties of a model class should be nullable or marked as "Required" to avoid under-posting.
• 9093 - [C#] New rule S6968: Actions that return a value should be annotated with ProducesResponseTypeAttribute containing the return type
• 9092 - [C#] New rule S6965: You should use HttpAttribute in API controller actions
• 9091 - [C#] New rule S6962: You should pool HTTP connections with HttpClientFactory
• 9089 - [C#] New rule S6960: Controllers should not have too many responsibilities

Bug Fixes

• 9193 - Fix AD0001: Named Attribute Arguments in S6930

False Positive

• 9219 - [C#] Fix S1144 FP: Getters/Setters of property with attribute are being flagged

Improvements

• 9187 - Update RSPEC before 9.25 release
• 9186 - [C#] Rule S6961: Implement CodeFix

Rule deprecations and deletions

• 9175 - [VB.NET] Delete S2353: Remove deprecated rule
• 9189 - [C#] Deprecate S6803

v9.24.0.89429: 9.24

Compare Source

Hey everyone,
This release contains one new ASP.NET Rule (S6961) and several general improvements and fixes. Enjoy!

Improvements

• 9090 - [C#] New rule S6961 for C#: API Controllers should derive from ControllerBase instead of Controller
• 8696 - Fix coverage aggregation from multiple reports
• 9048 - Create SonarAnalyzer.CSharp.Styling project
• 7774 - [C#, VB.NET] Fix S1144: Nested type constructor accessibility is wrong in the rule message
• 8980 - Update RSPEC before 9.24 release

Bug Fixes

• 9113 - [C#, VB.NET] AD0001: ArgumentNullException in SymbolicExecutionRunner
• 8977 - [C#] CfgAllPathValidator AreAllSuccessorsValid Stack Overflow on Windows and error MSB6006 in Linux Codespaces

False Positive

• 9063 - [C#, VB.NET] Fix S2094 FP: Should not raise for messages
• 9062 - [C#, VB.NET] Fix S2094 FP: Documentation using the DefaultDocumentation package
• 7591 - [C#, VB.NET] Fix S2094 FP: Implicit parameterless constructor widens the scope of the base class constructor
• 8163 - [C#, VB.NET] Fix S3878 FP: Jagged arrays

False Negative

• 6724 - [C#, VB.NET] Fix S1144 FN: Unused private getters and private setters
• 6699 - [C#] Fix S1144 FN: Unused local functions

v9.23.2.88755: 9.23.2

Compare Source

Hello, everyone!

Today we are doing a bug fix release that also addresses a couple of false positives. We deprecated VB support for S6931 and removed the rule from the "Sonar Way" quality profile for VB.

Special thanks to @​Corniel for fixing #​9019!

Bug fix

• 9022 - S6931 and S6934 raises AD0001 warnings

Improvements

• 9075 - Update RSPEC before 9.23.2 release

False Positive

• 9011 - [C#] Fix S2094 FP: Primary constructor calling base class constructor
• 8905 - [C#, VB.NET] Fix S2259 FP: PropertyReference does not learn from the underlying symbol

v9.23.1.88495: 9.23.1

Compare Source

Bug Fixes

• 8984 - Fix StackOverflow in CfgAllPathValidator.AreAllSuccessorsValid
• 8991 - [C#, VB.NET] Fix TypeInitializationException in SymbolStartAnalysisContextWrapper

False Positive

• 8532 - [C#, VB.NET] Fix S1144 FP: Do not raise on serializable members

v9.23.0.88079: 9.23

Compare Source

Hello everyone!
This release comes with two new rules for ASP.NET, false positive fixes, and other improvements.

A big thank you to @​Corniel for their external contribution with #​8898!

New Rules

• 8872 - [C#] New rule S6934: You should specify the RouteAttribute when an HttpMethodAttribute is specified at an action level
• 8870 - [C#, VB.NET] New rule S6931: ASP.NET controller actions should not have a route template starting with "/"

False Positives

• 8898 - [C#] Fix S3993 FP: Allow abstract attributes not to decorate Attribute usage
• 8510 - [C#] Fix S3878 FP: When the input array is a collection expression with the spread operator
• 8260 - [C#] Fix S1117 FP: Field/property instances are not accessible from static methods
• 7709 - [C#] Fix S2094 FP: Marker interface not detected when using records
• 6633 - [C#] Fix S2857 FP: Rule is not checking SQL keywords in const interpolated string

Other improvements and fixes

• 8935 - [C#] Rule S6602: Improve the logging message when recommending for Array.Find
• 7999 - [C#] Fix S1125 codefix: Do not add ! when transforming x == false.

v9.22.0.87781: 9.22

Compare Source

New Rules

• 8869 - [C#, VB.NET] New rule S6930: Backslash should be avoided in route templates
• 8844 - [C#] New rule S3416: Loggers should be named for their enclosing types
• 8840 - [C#] New rule S6675: Trace.WriteLineIf should not be used with TraceSwitch levels
• 8847 - [C#] New rule S2139: Exceptions should be either logged or rethrown but not both
• 8845 - [C#] New rule S6664: Too many logging calls within a code block
• 8843 - [C#] New rule S6672: Generic logger injection should match enclosing type
• 8842 - [C#] New rule S6669: Logger field names should comply with a naming convention
• 8841 - [C#] New rule S6670: Trace.Write and Trace.WriteLine should not be used
• 8769 - [C#] New rule S6673: Log message template placeholders should be in the right order
• 8846 - [C#] New rule S1312: Logger fields should be private static readonly [Non-SonarWay]

False Positive

• 7088 - [C#, VB.NET] Fix S2589 FP: When local is assigned in for loop
• 8264 - [C#, VB.NET] Fix S2583 FP: Code wrongly considered unreachable
• 8891 - [C#] Fix S2629 FP: Allow concatenation of constants

v9.21.0.86780: 9.21

Compare Source

New Rules

• 8771 - [C#] New rule S6678: Use PascalCase for named placeholders
• 8770 - [C#] New rule S6674: Log message template should be syntactically correct
• 8768 - [C#] New rule S2629: Logging templates should be constant
• 8767 - [C#] New rule S6677: Named placeholders should be unique
• 8766 - [C#] New rule S6667: Exceptions should be passed as an argument when logging in a catch clause
• 8765 - [C#] New rule S6668: Logging arguments should be passed to the correct parameter

Improvements

• The following rules were promoted to the SonarWay profile: S127, S1244, S1696, S1192, S1994, S2701, S2955

Bug Fixes

• 8787 - [C#] Fix AD0001: SonarAnalyzer.Rules.CSharp.SymbolicExecutionRunner throws an exception on unknown Numeric Constraints

False Positive

• 8823 - [C#] Fix S2701 FP: avoid raising for xUnit Assert.True()
• 6772 - [C#] Fix S4507 FP: Error raised on .NET 7 although the debug feature is deactivated

v9.20.0.85982: 9.20

Compare Source

Hey everyone!

This release brings a vast number of improvements. The main focus lies on improving the capabilities of our Symbolic Execution engine, which results in much more accurate findings. The biggest visible impact is a significant reduction in false positives around loops for the rules S2583 and S2589.

And a big thank you to @​rcatley for their external contribution!

Bug Fixes

• 8642 - [C#] Exception in SonarAnalyzer.Rules.CSharp.SymbolicExecutionRunner

False Positive

• 8678 - [C#, VB.NET] Fix S2583 FP: Variable Updated in Catch Block
• 8028 - [C#, VB.NET] Fix S2583 FP: Loop with manually incremented counter
• 8449 - [C#, VB.NET] Fix S2589 FP: Change this condition so that it does not always evaluate to 'True'
• 8495 - [C#, VB.NET] Fix S2583/S2589 FP: Return inside lock and using causes FP after the block
• 8428 - [C#, VB.NET] Fix S2583/S2589 FP: For loop with Array.Length
• 8483 - [C#, VB.NET] Fix S4158 FP: Should not report on HashSet.UnionWith for readonly fields.
• 8739 - [C#] Fix S4049 FP: Do not raise on methods with generic parameters
• 8638 - [C#] Fix S2386 & S3887 FP: should not be raised for FrozenDictionary and FrozenSet
• 8611 - [C#] Fix S2372 FP: Add support for method invocations (@​rcatley)
• 8567 - [C#] Fix S2325 FP: Primary Constructor Support

False Negative

• 8486 - [C#] Fix S2589 FN: Tuple binary operations (comparison)

Improvements

• 8010 - [C#, VB.NET] S2589: Improve message in the case of null propagating operator
• 7866 - [C#, VB.NET] SE: Allow collection tracking even when S4158 is not active
• 8499 - [C#] SE: Learn number constraints from relational pattern
• 8651 - Update RSPEC before 9.20 release

---

Configuration

📅 Schedule: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[renovate]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.