fix: attachment content #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratik136
previously approved these changes
Jan 17, 2024
rzaracota
force-pushed
the
work/issue/51-attachment-encoding
branch
2 times, most recently
from
190d4a2
to
f2fc69f
Compare
rzaracota
force-pushed
the
work/issue/51-attachment-encoding
branch
from
f2fc69f
to
5b18e94
Compare
lifebeyondfife
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in resolution of #51 the request body for attachments was wrapped in a second param container causing the attachment to be a serialized representation of the attachment metadata instead of the attachment data itself