Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests + Restore them to the pipeline #71

Merged
merged 14 commits into from
Aug 27, 2024
Merged

Fix integration tests + Restore them to the pipeline #71

merged 14 commits into from
Aug 27, 2024

Conversation

jsimonsmartsheet
Copy link
Contributor

@jsimonsmartsheet jsimonsmartsheet commented May 11, 2024 •
edited
Loading

This PR

  1. Makes the integration tests compilable.
  2. Adds compilation of the integration tests to the build
  3. Marks off failing tests as ignore + fixes some tests
  4. Removes unused broken docs generation project.

jsimonsmartsheet
jsimonsmartsheet commented May 11, 2024
View reviewed changes
Copy link
Contributor Author

@jsimonsmartsheet jsimonsmartsheet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just testing authentication

@jsimonsmartsheet jsimonsmartsheet changed the title test commit draft MR to fix unit tests May 28, 2024
@jsimonsmartsheet jsimonsmartsheet changed the title draft MR to fix unit tests draft: fix unit tests May 28, 2024
@jsimonsmartsheet jsimonsmartsheet changed the title draft: fix unit tests draft: fix integration tests Jul 22, 2024
@jsimonsmartsheet jsimonsmartsheet changed the title draft: fix integration tests Fix integration tests + Restore them to the pipeline Aug 9, 2024
@jsimonsmartsheet jsimonsmartsheet marked this pull request as ready for review August 19, 2024 00:32
timothodge
timothodge approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@timothodge timothodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes, and thank you John for deep diving on optional parameters and other issues that were brought up.

@timothodge timothodge merged commit 9562f6f into mainline Aug 27, 2024
1 check passed
@timothodge timothodge deleted the test branch August 27, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothodge timothodge timothodge approved these changes

Assignees

@timothodge timothodge

@mykelbengineer mykelbengineer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsimonsmartsheet @timothodge @mykelbengineer