-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration tests + Restore them to the pipeline #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just testing authentication
jsimonsmartsheet
force-pushed
the
test
branch
7 times, most recently
from
July 21, 2024 22:40
ba84424
to
e4bcb9c
Compare
jsimonsmartsheet
force-pushed
the
test
branch
2 times, most recently
from
August 8, 2024 16:11
14673fc
to
37b0fe5
Compare
jsimonsmartsheet
changed the title
draft: fix integration tests
Fix integration tests + Restore them to the pipeline
Aug 9, 2024
jsimonsmartsheet
commented
Aug 9, 2024
timothodge
reviewed
Aug 19, 2024
timothodge
reviewed
Aug 19, 2024
timothodge
reviewed
Aug 19, 2024
timothodge
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the changes, and thank you John for deep diving on optional parameters and other issues that were brought up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR