Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKS-2057: Bump CAPI to v1.6.3 #174

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

haijianyang
Copy link
Contributor

Issue

Bump CAPI to v1.6.3

Change

Management Cluster: v1.25.x -> v1.29.x
Workload Cluster: v1.23.x -> v1.29.x

升级的组件:

  • controller-runtime v0.16.5
  • cert-manager v1.14.4
  • controller-gen v0.13.0
  • golangci-lint v1.55.2
  • ginkgo v2.13.1
  • Go 1.21.8

新增:

Bug Fixes:

Test

参考 E2E

@@ -75,4 +77,10 @@ func (o *Options) defaults() {
if o.Scheme == nil {
o.Scheme = runtime.NewScheme()
}

if ns, ok := os.LookupEnv("POD_NAMESPACE"); ok {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POD_NAMESPACE CAPE 部署时好像没有配置这个ENV,类似这样?

          - name: POD_NAMESPACE
            valueFrom:
              fieldRef:
                fieldPath: metadata.namespace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认就不需要设置。有需要再配置。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haijianyang haijianyang merged commit 26638fb into smartxworks:master Apr 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants