Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support different namespace for infra resources #38

Conversation

scuzhanglei
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #38 (50d30b0) into main (09c3204) will increase coverage by 0.90%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   39.95%   40.86%   +0.90%     
==========================================
  Files           3        3              
  Lines         453      465      +12     
==========================================
+ Hits          181      190       +9     
- Misses        241      243       +2     
- Partials       31       32       +1     
Impacted Files Coverage Δ
controllers/virtinkcluster_controller.go 50.34% <50.00%> (-0.72%) ⬇️
controllers/virtinkmachine_controller.go 36.79% <91.66%> (+1.63%) ⬆️

@scuzhanglei scuzhanglei force-pushed the support-specific-namespace-for-infra-resources branch from 9593585 to ed2d300 Compare May 23, 2023 02:19
@scuzhanglei scuzhanglei force-pushed the support-specific-namespace-for-infra-resources branch from ed2d300 to 50d30b0 Compare May 23, 2023 03:44
@scuzhanglei scuzhanglei merged commit 0244207 into smartxworks:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants