Add PHP 8.4 support to Smarty #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisskid
reviewed
Nov 21, 2024
| */ | ||
| public function __construct( | ||
| string $message = "", | ||
| int $code = 0, | ||
| ?string $filename = null, | ||
| ?int $line = null, | ||
| Throwable $previous = null | ||
| ?\Throwable $previous = null |
There was a problem hiding this comment.
why did you add the backslash?
There was a problem hiding this comment.
Mostly because it was also added in the PR for V5 https://github.com/smarty-php/smarty/pull/1043/files#diff-d0f40f666506e3868faaf237c1f5a7731be2cd3c96bfa986b564f7c765b42bb5R26
But I can remove it
There was a problem hiding this comment.
Ah but I'm dumb there's no namespace in smarty 4, so not needed
|
@jolelievre couple of issues with the unit tests, I'm afraid. |
|
Ok thanks @wisskid I'll look into it |
jolelievre
force-pushed
the
smarty4-php84-compatibility
branch
from
f83f926
to
ede06e7
Compare
|
@wisskid it should be good now, at least locally I don't have any errors anymore, I had missed some E_STRICT |
jolelievre
force-pushed
the
smarty4-php84-compatibility
branch
from
ede06e7
to
0fd7a07
Compare
wisskid
approved these changes
Nov 21, 2024
|
Thanks @wisskid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly a backport of #1043 for version 4
This pull request updates the code base to support the deprecations introduced in PHP 8.4. It should be backwards compatible.
Updated the function signatures that had implicit null assignment to typed parameters.
Added PHP 8.4 to the 'run tests'-shell script.
Bumped the PHP version in the README.md