Max/custom parameters #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 15, 2024 14:30
maxwellpothier
requested review from
ducanbeu and
smartyskon
and removed request for
ducanbeu
smartyskon
requested changes
Nov 20, 2024
examples/international_street.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| const SmartySDK = require("smartystreets-javascript-sdk"); | |||
| const SmartySDK = require("../dist/cjs/index.cjs"); | |||
There was a problem hiding this comment.
Is this the right import?
|
|
||
| await handleRequest(lookup1) | ||
| await handleRequest(lookup2) | ||
| // lookup1.addCustomParameter("input_id", 1234); |
There was a problem hiding this comment.
Are these supposed to be commented?
examples/international_street.js
Outdated
|
|
||
| function displayResult(result) { | ||
| console.log(result.result[0].components); | ||
| // console.log(result); |
examples/us_autocomplete_pro.js
Outdated
| @@ -36,14 +40,14 @@ lookup.preferStates = ["IL"]; | |||
| lookup.preferRatio = 33; | |||
| lookup.source = "all"; | |||
|
|
|||
| await handleRequest(lookup, "Using Filter and Prefer"); | |||
| // await handleRequest(lookup, "Using Filter and Prefer"); | |||
There was a problem hiding this comment.
are these supposed to be commented?
examples/us_enrichment.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| const SmartySDK = require("smartystreets-javascript-sdk"); | |||
| const SmartySDK = require("../dist/cjs/index.cjs"); | |||
There was a problem hiding this comment.
is this the right import?
examples/us_extract.js
Outdated
| @@ -1,15 +1,11 @@ | |||
| const SmartySDK = require("smartystreets-javascript-sdk"); | |||
| const SmartySDK = require("../dist/cjs/index.cjs"); | |||
There was a problem hiding this comment.
is this the right import?
examples/us_extract.js
Outdated
|
|
||
| // for client-side requests (browser/mobile), use this code: | ||
| let key = process.env.SMARTY_EMBEDDED_KEY; | ||
| const credentials = new SmartyCore.SharedCredentials(key); |
There was a problem hiding this comment.
Are we supposed to remove these lines?
examples/us_zipcode.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| const SmartySDK = require("smartystreets-javascript-sdk"); | |||
| const SmartySDK = require("../dist/cjs/index.cjs"); | |||
There was a problem hiding this comment.
is this the right import?
examples/us_zipcode.js
Outdated
| @@ -8,7 +8,7 @@ const Lookup = SmartySDK.usZipcode.Lookup; | |||
| // const credentials = new SmartyCore.StaticCredentials(authId, authToken); | |||
|
|
|||
| // for client-side requests (browser/mobile), use this code: | |||
| let key = process.env.SMARTY_EMBEDDED_KEY; | |||
| let key = "your key"; | |||
There was a problem hiding this comment.
is there a reason we aren't using the env file now?
smartyskon
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClickUp: https://app.clickup.com/t/86b2rzrpy
To test: the examples are set up in a way to test with a single address, just plug in your secret key. I'll make sure to revert the examples this time.