Parse test duration correctly for >= go 1.5 #438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2016
| func parseTestFunctionDuration(line string) float64 { | ||
| line = strings.Replace(line, "(", "", 1) | ||
| fields := strings.Split(line, " ") | ||
| return parseDurationInSeconds(fields[3]+"s", 2) | ||
| timeStr := fields[3]+"s" | ||
| if strings.HasSuffix(timeStr, "s)s") { |
There was a problem hiding this comment.
why "s)s" ? wouldn't it be "s)" ?
There was a problem hiding this comment.
The < go 1.5 case is treated as the default and so in the previous line we have
timeStr := fields[3]+"s"
For < go 1.5 a line like
--- PASS: TestOldSchool_PassesWithMessage (0.03 seconds)
would have fields[3] == 0.03 and timeStr == 0.03s
For >= go 1.5 with input like
--- PASS: TestOldSchool_PassesWithMessage (0.03s)
we'd have fields[3] == 0.03s) and timeStr == 0.03s)s
riannucci
added a commit
that referenced
this pull request
Oct 21, 2021
This updates the tests to include some changes from Pull #438. I believe this confirms that the pull isn't actually needed.
Merged
riannucci
added a commit
that referenced
this pull request
Oct 21, 2021
This updates the tests to include some changes from Pull #438. I believe this confirms that the pull isn't actually needed.
|
Current parser seems to be correct w/ updated tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently parsing test durations is broken for go 1.5 and above. All test durations are currently reported as 0.00 seconds. This pull request contains a small fix.