-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StackMode to make stack traces configurable #588
Conversation
Thanks, this is exactly what I want. |
Any chance for someone to review this? |
Thanks @chrishili What's next step. Any change to merge this and make a release? |
Hm... I'm not sure why this wasn't merged... If by any chance you're still using goconvey, can you confirm that this still works? |
why this wasn't merged ? |
Have been using the |
Neat! I like it :) |
😱 I should have checked against the latest version of master when in fact I had been using a fork based off a version that was more than a year old. This is now leading to a compile error when running tests. It's a single line change, so I submitted PR #633 to address it. Please merge and re-release 1.6.5. |
Can someone guide me on how to use it now? Where can I set the StackMode while running go test? |
Thanks @ezk84 @riannucci ❤️ 🥳 |
|
Adds StackMode as an optional parameter to Convey, in the same way that FailureMode is implemented.
StackMode can be Error (default - print stack only on errors) or Fail (print stack for failure and errors).
Fixes: Make stacktrace on error optional #566