-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple update script and CI check for 3rd party libs. #634
Conversation
@SunSparc heyo; It looks like this repo never got moved to travis-ci.com, and I don't have permission to set this up (and you seem to be currently attached to smartystreets, which owns this repo :)). There are some long-standing javascript CVE pull requests which I'd like to merge, but because this repo currently includes the SOURCE of the javascript, I wanted some extra assurance that the checked-in js files actually correspond to what's in the .url files next to them. However this only works if Travis can actually Do The Thing™️ :). Please let me know if I should bug someone else to do this! Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
@SunSparc right; however I was really mostly pinging about getting Travis set up again for this repo :D. Right now nothing is running the tests that were in this PR. |
@riannucci, I see. I have not setup a repo on travis-ci.com before so I am not sure what the requirements are. What permissions do you require in order to set it up? |
I'm not sure, but I think it needs someone who "owns" the repo (I'm categorized as an "outside collaborator" a designation I'm not really looking to expand 😛). If you log into travis-ci.com and do the github auth dance, I think it should show this repo as one that you 'own'? (Again, I didn't mean to pick on you in particular, I just clicked on the smartystreets org and you were somewhere on the page 😀.) |
With how little activity there is on this project, obtaining a Travis CI subscription does not seem reasonable. |
Er... shouldn't the free plan work? I just don't have permission to activate it for this repo. |
Hmm... that is confusing. I was looking on their pricing page, which only shows a free trial: https://www.travis-ci.com/pricing/ Then I found this page that shows an actual free plan: https://app.travis-ci.com/plans Travis integration is now installed for |
Thanks!! |
(Though... I don't see anything on https://app.travis-ci.com/github/smartystreets/goconvey?) |
I'll upload another PR and see if something happens |
It appears that Travis CI might be having some issues right now. I went through their setup process and now they tell me:
Apparently other people are also having a similar problem with Travis CI:
They have a
If I try to sign up for the beta it requires that all repositories are migrated. That is quite presumptuous of Travis CI. There is also this episode that apparently happened last month which raises some flags: Travis CI flaw exposed secrets of thousands of open source projects |
This should make updates to .url files safer.