Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #639: Disable pre-compilation for Go 1.16+ #640

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

riannucci
Copy link
Collaborator

The Go compiler cache already mitigates the main benefit of the
previous go test -i invocations. The previous replacement (running
go test) makes goconvey slower and also breaks the UI :).

At some point (I think) this should all be restructured so that we
can pre-build all test binaries with a single go test -c
invocation (so that we can take advantage of Go's internal
compile scheduling). For now we'll just skip the pre-compilation
step in order to un-break goconvey.

The Go compiler cache already mitigates the main benefit of the
previous `go test -i` invocations. The previous replacement (running
`go test`) makes goconvey slower and also breaks the UI :).

At some point (I think) this should all be restructured so that we
can pre-build all test binaries with a single `go test -c`
invocation (so that we can take advantage of Go's internal
compile scheduling). For now we'll just skip the pre-compilation
step in order to un-break goconvey.
@riannucci riannucci merged commit a743bd0 into master Oct 21, 2021
@riannucci riannucci deleted the fix_dropped_test_results branch October 21, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant