Use temporary directory for coverage reports. #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimsht
reviewed
Oct 26, 2021
| } | ||
|
|
||
| done := make(chan os.Signal) | ||
| signal.Notify(done, os.Interrupt, syscall.SIGTERM, syscall.SIGINT) |
There was a problem hiding this comment.
I'm not sure this will compile on Windows. Try GOOS=windows.
There was a problem hiding this comment.
Surprisingly, it does exist: https://cs.opensource.google/go/go/+/master:src/syscall/types_windows.go;l=64?q=SIGTERM&ss=go%2Fgo:src%2Fsyscall%2F
Though I believe its just a noop
riannucci
force-pushed
the
covertempdir
branch
from
bf84fcd
to
385d056
Compare
This keeps things simple and just uses one temporary directory per `goconvey` process to store all coverage reports, with an optional flag to leak the temporary directory after shutting down the server. This will allow `goconvey` to properly report coverage for code using go modules. Fixes #618 Fixes #564
riannucci
force-pushed
the
covertempdir
branch
from
385d056
to
180ccef
Compare
riannucci
commented
Oct 26, 2021
| <-done | ||
| log.Println("shutting down") | ||
| if err := srv.Shutdown(nil); err != nil { | ||
| log.Printf("failed to shutdown: %s\n", err) |
There was a problem hiding this comment.
Fixed this Fatalf as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps things simple and just uses one temporary directory per
goconveyprocess to store all coverage reports, with an optionalflag to leak the temporary directory after shutting down the server.
This will allow
goconveyto properly report coverage for codeusing go modules.
Fixes #618
Fixes #564