Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade deps, update to go 1.18 #674

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

srabraham
Copy link
Contributor

@srabraham srabraham commented Apr 4, 2023

go 1.18 is the most recent supported version of Go, so it seems reasonable to upgrade to that. This upgrade is needed to pull in the latest version of smartystreets/assertions, which I want in here for this fix of mine: smarty/assertions@a83f75f

This also replaces all "interface{}" with "any", since go 1.18 added that. That was already done in the assertions repo the other day.

Note that this command passes:
go test -timeout=1s -race -cover -short -count=1 ./...

but the integration test file fails. That failure is already in the repo at HEAD though.

This is a partial fix to #665, since it pulls in the aforementioned assertions fix. See smarty/assertions#50

go 1.18 is the most recent supported version of Go, so it seems reasonable
to upgrade to that. This upgrade is needed to pull in the latest version
of smartystreets/assertions, which I want in here for this fix of mine:
smarty/assertions@a83f75f

This also replaces all "interface{}" with "any", since go 1.18 added that.
That was already done in the assertions repo the other day.

Note that this command passes:
go test -timeout=1s -race -cover -short -count=1 ./...

but the integration test file fails. That failure is already in the repo
at HEAD though.
@srabraham
Copy link
Contributor Author

FYI @riannucci or others

@riannucci
Copy link
Collaborator

lgtm will pull and tag when I'm at computer

@srabraham
Copy link
Contributor Author

bump @riannucci 😄

@riannucci
Copy link
Collaborator

(sorry for the delay!)

@riannucci riannucci merged commit 4aefd2b into smartystreets:master Apr 7, 2023
@srabraham
Copy link
Contributor Author

Thanks, Robbie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants