fix(Validators): fix incorrect use of FormName to BaseUrl #2260
Annotations
21 warnings
|
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use the latest version of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/
|
|
Test:
src/Utils/Startup/ServiceCollectionExtensions.cs#L568
'ConnectionMultiplexer.IncludePerformanceCountersInExceptions' is obsolete: 'Please use ConfigurationOptions.IncludePerformanceCountersInExceptions instead - this will be removed in 3.0.'
|
|
Test:
src/Providers/PaymentProvider/FakePayProvider.cs#L19
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Test:
src/Helpers/DocumentCreation/DocumentCreationHelper.cs#L14
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Test:
src/Providers/Analytics/FakeAnalyticsProvider.cs#L13
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Test:
src/Services/AddressService/AddressService.cs#L222
Re-throwing caught exception changes stack information (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2200)
|
|
Test:
src/Services/AddressService/AddressService.cs#L234
Re-throwing caught exception changes stack information (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2200)
|
|
Test:
tests/unit-tests/UnitTests/Providers/TemplatedEmailProvider/NotifyTemplatedEmailProviderTests.cs#L21
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Test:
tests/unit-tests/UnitTests/Workflows/EmailWorkflowTests.cs#L60
Test methods should not use blocking task operations, as they can cause deadlocks. Use an async test method and await instead. (https://xunit.net/xunit.analyzers/rules/xUnit1031)
|
|
Test:
tests/unit-tests/UnitTests/Helpers/CookieHelperTests.cs#L25
Use IHeaderDictionary.Append or the indexer to append or set headers. IDictionary.Add will throw an ArgumentException when attempting to add a duplicate key. (https://aka.ms/aspnet/analyzers)
|
|
Test:
tests/unit-tests/UnitTests/Validators/IntegrityChecks/Form/BookingFormCheckTests.cs#L168
Do not use Assert.Empty() to check if a value does not exist in a collection. Use Assert.DoesNotContain() instead. (https://xunit.net/xunit.analyzers/rules/xUnit2029)
|
|
Build:
src/Utils/Startup/ServiceCollectionExtensions.cs#L568
'ConnectionMultiplexer.IncludePerformanceCountersInExceptions' is obsolete: 'Please use ConfigurationOptions.IncludePerformanceCountersInExceptions instead - this will be removed in 3.0.'
|
|
Build:
src/Helpers/DocumentCreation/DocumentCreationHelper.cs#L14
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build:
src/Providers/PaymentProvider/FakePayProvider.cs#L19
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build:
src/Providers/Analytics/FakeAnalyticsProvider.cs#L13
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build:
src/Services/AddressService/AddressService.cs#L222
Re-throwing caught exception changes stack information (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2200)
|
|
Build:
src/Services/AddressService/AddressService.cs#L234
Re-throwing caught exception changes stack information (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2200)
|
|
Build:
src/Utils/Startup/ServiceCollectionExtensions.cs#L568
'ConnectionMultiplexer.IncludePerformanceCountersInExceptions' is obsolete: 'Please use ConfigurationOptions.IncludePerformanceCountersInExceptions instead - this will be removed in 3.0.'
|
|
Build:
src/Helpers/DocumentCreation/DocumentCreationHelper.cs#L14
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build:
src/Providers/PaymentProvider/FakePayProvider.cs#L19
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build:
src/Providers/Analytics/FakeAnalyticsProvider.cs#L13
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
Loading