Skip to content

Commit

Permalink
revert(GeneratedIdConfigurationCheck): comment out added check to inv…
Browse files Browse the repository at this point in the history
…estigate locally
  • Loading branch information
lydiagray committed Nov 9, 2023
1 parent 3c3d665 commit 6f2f83a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ public IntegrityCheckResult Validate(FormSchema schema)
"Generated Id Configuration Check, " +
"'GeneratedReferenceNumberMapping' and 'ReferencePrefix' must both have a value.");

if (schema.Pages.Any(page => page.Behaviours.Any(behaviour => behaviour.BehaviourType.Equals(EBehaviourType.SubmitWithoutSubmission))) && !schema.GenerateReferenceNumber)
result.AddFailureMessage(
"Generated Id Configuration Check, if using SubmitFormNoAction then 'GeneratedReferenceNumber' must be true.");
//if (schema.Pages.Any(page => page.Behaviours.Any(behaviour => behaviour.BehaviourType.Equals(EBehaviourType.SubmitWithoutSubmission))) && !schema.GenerateReferenceNumber)
// result.AddFailureMessage(
// "Generated Id Configuration Check, if using SubmitFormNoAction then 'GeneratedReferenceNumber' must be true.");

return result;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public void CheckGeneratedIdConfiguration_DoesNotThrow_ApplicationException_Gene
Assert.DoesNotContain(IntegrityChecksConstants.FAILURE, result.Messages);
}

[Fact]
[Fact(Skip = "Skipped for investigation")]
public void CheckGeneratedIdConfiguration_Throw_ApplicationException_WhenGenerateReferenceNumber_IsFalse_And_SubmitWithoutSubmission_IsUsed()
{
// Arrange
Expand Down

0 comments on commit 6f2f83a

Please sign in to comment.