Disable click listener detection and bump to v1.63.3.

smblott-github · Apr 1, 2018 · 5745bb3 · 5745bb3
1 parent 2983802
commit 5745bb3
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -185,6 +185,8 @@ In `master` (not yet released)
     - Fix [#2958](https://github.com/philc/vimium/issues/2958#issuecomment-366488659), link hints broken for `target="_blank"` links.
 - 1.63.2 (Firefox only):
     - Fix [#2962](https://github.com/philc/vimium/issues/2962), find mode broken on Firefox Quantum.
+- 1.63.3:
+    - Fix [#2997](https://github.com/philc/vimium/issues/2997), Vimium's DOM injection breaks Google Pay site.
 
 1.62 (2017-12-09)
 

diff --git a/content_scripts/injected.coffee b/content_scripts/injected.coffee
@@ -1,3 +1,6 @@
+# NOTE(smblott) Disabled pending resolution of #2997.
+return
+
 # The code in `injectedCode()`, below, is injected into the page's own execution context.
 #
 # This is based on method 2b here: http://stackoverflow.com/a/9517879, and

diff --git a/content_scripts/link_hints.coffee b/content_scripts/link_hints.coffee
@@ -706,8 +706,9 @@ LocalHints =
         isClickable = true
         reason = "Open."
 
-    # Detect elements with "click" listeners installed with `addEventListener()`.
-    isClickable ||= element.hasAttribute "_vimium-has-onclick-listener"
+    # NOTE(smblott) Disabled pending resolution of #2997.
+    # # Detect elements with "click" listeners installed with `addEventListener()`.
+    # isClickable ||= element.hasAttribute "_vimium-has-onclick-listener"
 
     # An element with a class name containing the text "button" might be clickable.  However, real clickables
     # are often wrapped in elements with such class names.  So, when we find clickables based only on their

diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
   "manifest_version": 2,
   "name": "Vimium",
-  "version": "1.63.2",
+  "version": "1.63.3",
   "description": "The Hacker's Browser. Vimium provides keyboard shortcuts for navigation and control in the spirit of Vim.",
   "icons": {  "16": "icons/icon16.png",
               "48": "icons/icon48.png",