forked from HiroyukiSakoh/EchoDotNetLite
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smdn.MSBuild.ProjectAssets.Commonを導入する #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilding all projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NuGetパッケージをリリースするにあたり、主にアセンブリ属性の指定を共通化する目的で
Smdn.MSBuild.ProjectAssets.Common
を導入する。あわせて、このパッケージの導入により有効になるcode analysis/code styleの警告を修正する。
Considerations
EchoDotNetLite
とのAPI互換性をできるだけ維持するために、それを破壊する可能性のある警告は修正せず、無効化する。今後API互換性の維持を継続しなくなった時点で、警告を再度有効化する。
また上記と同様の理由で、
Smdn.MSBuild.ProjectAssets.Library
の導入も現時点では見送る。