Bump min required mpi4py to 3.1.1 #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timryanb feel free to change the version number as required to match with the other stuff you're doing |
|
I would suggest just updating to latest bugfix, 3.1.4, which is the latest on pypi |
|
mpi4py 3.1.1 as a minimum seems fine to me. I don't see anything in the release notes for (3.1.1+) that would affect TACS and want to avoid forcing users to upgrade unless there's a specific reason |
timryanb
approved these changes
Jan 30, 2023
|
I'm going to remove the version bump and merge this PR as-is for now to fix the broken installation. I'll make a new separate PR with the version bump (PR #177 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpi4py 3.1.0 has a typo in it's python dependencies definition that causes errors during pip install (see here and here). Due to a new major release of setuptools (best guess), this just started causing build errors on our docker images (see here)
This PR therefore bumps the minimum required version of mpi4py to 3.1.1 where the error is fixed.
Also includes the OpenMDAO version guard from #174
Bumping TACS version to 3.2.0