Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cython 3 compatibility fixes #231

Merged
merged 8 commits into from
Jul 28, 2023
Merged

cython 3 compatibility fixes #231

merged 8 commits into from
Jul 28, 2023

Conversation

timryanb
Copy link
Collaborator

@timryanb timryanb commented Jul 19, 2023 •
edited by A-CGray
Loading

  • Separating cython and cpp declarations into separate pxd files. Couldn't get it to work w/o doing this, so this seems to be required now (see here)
  • Fixing cython import statements and adding some __init__.pxd files
  • Utilizing numpy.PyArray_SetBaseObject method instead of assigning base object directly

Closes #229

@timryanb timryanb changed the title cython 3 fixes cython 3 compatibility fixes Jul 19, 2023
@timryanb timryanb linked an issue Jul 19, 2023 that may be closed by this pull request
TACS' cython interface is not compatible with the latest major version #229
Closed
@timryanb timryanb marked this pull request as ready for review July 20, 2023 13:06
A-CGray
A-CGray approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@A-CGray A-CGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@timryanb timryanb merged commit 15804d0 into smdogroup:master Jul 28, 2023
5 checks passed
@timryanb timryanb deleted the cython3 branch July 28, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-CGray A-CGray A-CGray approved these changes

@gjkennedy gjkennedy Awaiting requested review from gjkennedy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TACS' cython interface is not compatible with the latest major version
3 participants
@timryanb @A-CGray @gjkennedy