Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set height of search box to match surrounding boxes #322

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

paulschreiber
Copy link
Contributor

@paulschreiber paulschreiber commented Apr 19, 2022

Before:
image

After:
image

@smeijer
Copy link
Owner

smeijer commented Jun 7, 2022

It always did match, so something else changed as well. Did another leaflet version impact the size of the search and x icon? I'd love to apply a fix for this, but just bumping the pixels will break other environments.

I think we should do something with a flex box, giving the container a fixed height, and making the child elements center align within that. What do you think?

@smeijer smeijer force-pushed the develop branch 3 times, most recently from 7618154 to 6453ded Compare October 3, 2022 19:26
@smeijer
Copy link
Owner

smeijer commented Oct 3, 2022

Thanks, I'm going with it and get this merged :)

@smeijer smeijer changed the title Set height of search box to match surrounding boxes fix: set height of search box to match surrounding boxes Oct 3, 2022
@smeijer smeijer merged commit b9f54d7 into smeijer:develop Oct 3, 2022
@smeijer
Copy link
Owner

smeijer commented Oct 3, 2022

@all-contributors please add @paulschreiber for code

@allcontributors
Copy link
Contributor

@smeijer

I've put up a pull request to add @paulschreiber! 🎉

@smeijer
Copy link
Owner

smeijer commented Oct 3, 2022

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants