Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ls24004010/conversion to ds for unlimited string type #610

Merged

Conversation

GaetanoDiNatale
Copy link
Contributor

@GaetanoDiNatale GaetanoDiNatale commented Sep 12, 2024

Description

This work adds the ability to convert values of type UnlimitedStringType into a data structure during MOVEL operations.

Technical notes

To achieve the goal, data_definitions.kt was updated to handle UnlimitedStringType correctly, ensuring no modification or padding of unlimited strings.

Related to #LS24004010

Checklist:

  • If this feature involves RPGLE fixes or improvements, they are well-described in the summary.
  • There are tests for this feature.
  • RPGLE code used for tests is easily understandable and includes comments that clarify the purpose of this feature.
  • The code follows Kotlin conventions (run ./gradlew ktlintCheck).
  • The code passes all tests (run ./gradlew check).
  • Relevant documentation is included in the docs directory.

Copy link
Collaborator

@lanarimarco lanarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.
I just ask for a small additional effort by adding something to your test that helps me understand what happens when the content of £UIBME exceeds 4 characters.

@lanarimarco lanarimarco merged commit accedce into develop Sep 13, 2024
1 check passed
@lanarimarco lanarimarco deleted the bugfix/LS24004010/conversionToDsForUnlimitedStringType branch September 13, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants