feat: jobsubmission abstraction #504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* setting up paparazzi * setting up v3 instruction screen * added selfie capture screen ui and tests * add v2 UI * bump up VERSION (#455) * Bump the androidx group with 5 updates (#454) * Bump the agp group with 2 updates (#453) * add instruction screen to new ui * duplicate theme and cleaning up * updated selfie capture flow * updated tests --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix unsecure object serialization * updated CHANGELOG.md * updated CHANGELOG.md
* feat: scale document bitmaps based on available memory * chore: fix docv tests * feat: refactor on capture get memory first * chore: undo test crashlytics * fix: throw oom error when encountered * chore: update changelog * Update CHANGELOG.md Co-authored-by: Ed Fricker <888909+beastawakens@users.noreply.github.com> --------- Co-authored-by: Ed Fricker <888909+beastawakens@users.noreply.github.com>
* feat:sdk-navigation * feat: type safe nav wip * fix: undo tests renaming * feat: custom nav types * feat: working nav * feat:replace composables for enrollment with graph nav * feat: main graph and reusable composble for nav * feat: bump compose nav versions * feat: refactor with seperation between orchestrated and indvidual screens * fix: tests * chore: bump compose navigation version * feat: docs * feat: main nav fixes * feat: nav complete * feat: nav complete * feat: nav complete * fix: unit tests for doc v and enhanced doc v * feat: callbacks fixes * feat: compose stack fixes and retries * feat: pr feedback fixes * feat: merge main * feat: fix transition issue delay * fix: nav cancelled actions * feat: pop transitions * feat: pop transitions on orch nav --------- Co-authored-by: Juma Allan <allanjuma@gmail.com>
* feat: bump version to 10.3.3 * feat: changelog format
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
|
Reopening as it was marked stale |
|
Persistent review updated to latest commit f4bce0e |
robin-ankele
requested changes
Jan 7, 2025
| } | ||
| } | ||
|
|
||
| fun onFinished(onResult: SmileIDCallback<BiometricKycResult>) = onResult(result!!) | ||
| override fun handleSubmissionFiles(jobId: String) { |
There was a problem hiding this comment.
Is this something we need to fix in this PR or you want to do in a follow up PR?
| @@ -113,7 +98,7 @@ class SelfieViewModel( | |||
| SharingStarted.WhileSubscribed(), | |||
| SelfieUiState(), | |||
| ) | |||
| var result: SmileIDResult<SmartSelfieResult>? = null | |||
| // var result: SmileIDResult<SmartSelfieResult>? = null | |||
There was a problem hiding this comment.
Should we remove it if we don't need it?
Comment on lines
+71
to
+73
| // var result: SmileIDResult<T> = SmileIDResult.Error( | ||
| // IllegalStateException("Document Capture incomplete"), | ||
| // ) |
| } | ||
| } | ||
|
|
||
| override fun handleSubmissionFiles(jobId: String) { |
There was a problem hiding this comment.
Do we need to implement this or should we add a comment that it's not needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://app.shortcut.com/smileid/story/13730/improve-error-handling-on-android-and-ios-sdk
Improve Error Handling on android and ios sdk.
Summary
Better abstraction for
Known Issues
n/a
Test Instructions
Screenshot
n/a